Hi Sebb,

2014/1/24 <s...@apache.org>

> Author: sebb
> Date: Fri Jan 24 16:00:35 2014
> New Revision: 1561045
>
> URL: http://svn.apache.org/r1561045
> Log:
> LANG-954 uncaught PatternSyntaxException in FastDateFormat on Android
>
> Modified:
>     commons/proper/lang/trunk/src/changes/changes.xml
>
> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
>
> Modified: commons/proper/lang/trunk/src/changes/changes.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/changes/changes.xml?rev=1561045&r1=1561044&r2=1561045&view=diff
>
> ==============================================================================
> --- commons/proper/lang/trunk/src/changes/changes.xml [utf-8] (original)
> +++ commons/proper/lang/trunk/src/changes/changes.xml [utf-8] Fri Jan 24
> 16:00:35 2014
> @@ -49,6 +49,7 @@
>
>    <release version="3.2" date="2014-01-01" description="Bug fixes and new
> features, at least requires Java 6.0">
>      <action issue="LANG-934" type="add" dev="mcucchiara">Add
> removeFinalModifier to FieldUtils</action>
> +    <action issue="LANG-954" type="fix" due-to="Michael Keppler"
> dev="sebb">uncaught PatternSyntaxException in FastDateFormat on
> Android</action>
>

Thanks for fixing this! I was afraid that I have to install an Android SDK
:-)
However, this doesn't look right. Please add the change to the changes for
3.3.

Benedikt


>      <action issue="LANG-863" type="add" due-to="Daneel S. Yaitskov"
> dev="sebb">Method returns number of inheritance hops between parent and
> subclass</action>
>      <action issue="LANG-932" type="fix" due-to="Ville Skyttä"
> dev="sebb">Spelling fixes</action>
>      <action issue="LANG-931" type="update" dev="britter"
> due-to="Christoph Schneegans">Misleading Javadoc comment in
> StrBuilderReader class</action>
>
> Modified:
> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java?rev=1561045&r1=1561044&r2=1561045&view=diff
>
> ==============================================================================
> ---
> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> (original)
> +++
> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
> Fri Jan 24 16:00:35 2014
> @@ -648,11 +648,12 @@ public class FastDateParser implements D
>           */
>          @Override
>          boolean addRegex(final FastDateParser parser, final StringBuilder
> regex) {
> +            // See LANG-954: We use {Nd} rather than {IsNd} because
> Android does not support the Is prefix
>              if(parser.isNextNumber()) {
> -
>  regex.append("(\\p{IsNd}{").append(parser.getFieldWidth()).append("}+)");
> +
>  regex.append("(\\p{Nd}{").append(parser.getFieldWidth()).append("}+)");
>              }
>              else {
> -                regex.append("(\\p{IsNd}++)");
> +                regex.append("(\\p{Nd}++)");
>              }
>              return true;
>          }
>
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to