On Sat, Jan 4, 2014 at 2:56 PM, Oliver Heger
<oliver.he...@oliver-heger.de>wrote:

> Maven build works fine with Java 1.5 and 1.7 on Windows 7. The ant build
> was successful, too. Artifacts and site look good.
>
> So +1.
>
> I tried to test the build with a JDK 1.4 using the profile, but got the
> error
> java.lang.UnsupportedClassVersionError:
> org/apache/maven/surefire/booter/ForkedBooter (Unsupported major.minor
> version 49.0)
>         at java.lang.ClassLoader.defineClass0(Native Method)
>         at java.lang.ClassLoader.defineClass(ClassLoader.java:539)
>         at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:12
> 3)
>         at java.net.URLClassLoader.defineClass(URLClassLoader.java:251)
>         at java.net.URLClassLoader.access$100(URLClassLoader.java:55)
>         at java.net.URLClassLoader$1.run(URLClassLoader.java:194)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at java.net.URLClassLoader.findClass(URLClassLoader.java:187)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:289)
>         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:274)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:235)
>         at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:302)
> Exception in thread "main"
>
> Obviously, even the surefire plug-in requires a JDK > 1.4.
>

Oliver, thank you for your review.


>
> There haven't been any changes on the site, so I repeat my comments from
> my last review:
> - The overview site needs to be updated for the new release (in the
> Releases section).
>

What would you change? I can update the site after the release. Right now
it says:

"The latest version v1.2, is JDK 1.3 compatible - Download
now!<http://commons.apache.org/exec/download_exec.cgi>.


For previous releases, see the Apache
Archive<http://archive.apache.org/dist/commons/exec/>
.

Version v1.1, is JDK 1.3 compatible. "



> - There are some findbugs errors, probably not that critical, but at
> least the one about inconsistent synchronization could need some
> investigation.
>

I can see a couple more FBs than for 1.1, the default encoding issues are
probably OK, not sure about the others. I think we can follow
release-early-release-often if there is an issue here.


> - The JIRA report only shows an error.
>

I'll have to fix that post-release.

Gary


>
> Oliver
>
> Am 03.01.2014 03:39, schrieb Gary Gregory:
> > Hello All:
> >
> > This is a VOTE to release Commons Exec 1.2-RC2
> >
> > The changes from RC1 are:
> > - Update the NOTICE.txt file fro 2014
> > - Update the source assembly to mark .sh files as executable.
> >
> > Feature and fix release. Requires a minimum of Java 1.3.
> >
> > The Apache Commons Exec team is pleased to announce the Apache
> > commons-exec-1.2 release!
> >
> > Apache Commons Exec is a library to reliably execute external processes
> > from within the JVM.
> >
> > Changes in this version include:
> >
> > New features:
> >
> > o Set names for started threads.  Issue: EXEC-55. Thanks to Dominik
> > Stadler.
> >
> > Fixed Bugs:
> >
> > o Issue: EXEC-68.
> >   Watchdog kills process immediately if timeout is too large.
> >   Thanks to Joel McCance.
> >
> > o Issue: EXEC-57.
> >   Applied the patch from Nickolay Martinov but the timeout disguises the
> > fact that the process might be still running.
> >   Therefore added a sanity check in order to throw an exception if the
> the
> > timeout for join() was exceeded.
> >   Thanks to Nickolay Martinov.
> >
> > o Issue: EXEC-60.
> >   Fixed dead lock by calling the timeout observers outside of the
> > synchronized block thereby removing on pre-requisite of a deadlock.
> >   Also added a test case to demonstrate that this problem is fixed (which
> > of course can not guarantee the absence of a dead lock).
> >   Thanks to Peter Kofler.
> >
> > o Issue: EXEC-52.
> >   Tests fail on HP-UX, because it uses a different syntax for the ping
> > command.
> >   Thanks to Nickolay Martinov.
> >
> > o Issue: EXEC-49.
> >   "Write dead end" IOException when using Piped streams
> w/PumpStreamHandler.
> >   When encountering a PipedOutputStream we will automatically close it to
> > avoid the exception.
> >   Thanks to Kevin Telford.
> >
> > o Issue: EXEC-34.
> >   Race condition prevent watchdog working using ExecuteStreamHandler.
> >   Patch submittd by Kristian Rosenvold.
> >   Thanks to Marco Ferrante.
> >
> > This VOTE is open for at least 72 hours until January 6 2014 at 10:00 PM
> > EST.
> >
> > The files:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-038/
> >
> > The tag:
> >
> > https://svn.apache.org/repos/asf/commons/proper/exec/tags/1.2-RC2
> >
> > The site:
> >
> > https://people.apache.org/~ggregory/commons-exec/1.2-RC2/site/
> >
> > Links to versions of sites and Javadocs will be live when deployed.
> >
> > Thank you,
> > Gary Gregory
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Reply via email to