On 12/28/2013 06:35 PM, Gilles wrote: > Hi. > > I've just attached the proposed implementation: > https://issues.apache.org/jira/browse/MATH-923 > > It is part of a new package "o.a.c.m.ml.neuralnet" that is supposed > to contain tools for creating artificial neural networks; however > the code has been written based on the single SOFM use case.
Please find below some comments based on your first patch: - SquareNeighbourhood to my understanding, this is only useful for the case of a 2d network, thus it should be in the package twod. - MapUtils As the utility methods there are very specific for SOFMs I would suggest to move this to the package sofm and maybe even rename it to SOFMUtils. - NeuronString / NeuronSquareMesh2D Somehow I like the level of abstraction between the very generic "Network" and these classes which represent a very specific neuronal net, i.e. a string of neurons in the 1D case and a mesh of neurons in the 2D case. At least it takes some time to understand the structure and relationship between them and I was wondering if they could extend a Network as this is their main purpose. - package sofm.util just a minor thing, but I would move the function classes there to the sofm package and make them package private. They are only used by the respective factories and I wonder if there is any other use for them. - NeighbourhoodSizeFunctionFactory has the same javadoc as the LearningFactorFunctionFactory. - general I understand that the main purpose of the neuronal network was to create the foundation for the SOFM, but what I was missing for the network was the part of the activation function. Right now, the network can be trained using the UpdateAction, but then one has to analyze the neurons itself, which is fine for the SOFM case. For the more general case, such an activation function can be used to generate the output of the network based on a given input. Do you have plans to further add something like this? - userguide There are really nice opportunities for graphical demos of a SOFM together with the already existing unit tests for the travelling salesman problem. Do you already work on something like this as otherwise I would be interested in creating such examples. The new code is really interesting and opens up a lot of other opportunities, thanks for your work on this. I will definitely look further into this topic. From my side, feel free to start committing your current status, we can surely discuss further issues afterwards. Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
