On Sat, Dec 21, 2013 at 10:34 AM, Oliver Heger <oliver.he...@oliver-heger.de
> wrote:

> Maven and ant builds work fine on Windows 8.1 with JDK 7 (I could not
> test with Java 6 unfortunately). Artifacts and site look good.
>
> Following minor nits (not blocking):
>

Thank you for the review!


> - Is the TODO file in the source distribution really needed? It is
> listed in the RAT report because it does not have a license.
>

I added the Apache header to the TODO file.

The TODO is explicitly included from the assembly src.xml and I think that
makes sense. If I get the src file, I should get it all.

- There are a few checkstyle errors which are very easy to fix (trailing
> spaces).
>

Fixed in SVN.

Gary


> +1
>
> Oliver
>
> Am 21.12.2013 05:09, schrieb Gary Gregory:
> > Hello All:
> >
> > This is a VOTE to release Commons Codec 1.9-RC1
> >
> > Feature and fix release. Requires a minimum of Java 1.6.
> >
> > Changes in this version include:
> >
> > Performance:
> > CODEC-174: Improve performance of Beider Morse encoder. Thanks to Thomas
> > Champagne.
> >
> > Fixed Bugs:
> > o CODEC-175: Beider Morse does not close Scanners used to read config
> > files.
> > o CODEC-172: Base32 decode table has spurious value. Thanks to Matt
> Bishop.
> > o CODEC-170: Link broken in Metaphone Javadoc. Thanks to Ron Wheeler,
> Henri
> > Yandell.
> > o CODEC-176: Spelling fixes in Javadoc and comments. Thanks to Ville
> > Skyttä.
> >
> >
> > This VOTE is open for at least 72 hours until December 23 2013 at 11:30
> PM
> > EST.
> >
> > The files:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-012/
> >
> > The tag:
> >
> > https://svn.apache.org/repos/asf/commons/proper/codec/tags/1.9-RC1
> >
> > The site:
> >
> > https://people.apache.org/~ggregory/commons-codec/1.9-RC1/site/
> >
> > Links to versions of sites and Javadocs will be live when deployed.
> >
> > Thank you,
> > Gary Gregory
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Reply via email to