Hi Thomas, thanks for your review.
Am 09.12.2013 22:04, schrieb Thomas Neidhart: > On 12/07/2013 06:55 PM, Oliver Heger wrote: >> Hi all, >> >> Commons BeanUtils 1.9.0 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/beanutils/ (svn >> revision 3852) >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-021/commons-beanutils/commons-beanutils/1.9.0/ >> >> Details of changes since 1.8.3 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txt >> >> The tag is here: >> >> http://svn.apache.org/repos/asf/commons/proper/beanutils/tags/BEANUTILS_1_9_0_RC1/ >> (svn revision 1548928) >> >> Site: >> >> >> KEYS: >> http://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner than 72 hours from now, i.e. after 1800 >> GMT 10-December 2013 >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... > > I tested the tag and got the following test error: > > Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 27.331 > sec <<< FAILURE! - in > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase > testMethodUtils_cache_memoryLeak(org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase) > Time elapsed: 15.489 sec <<< ERROR! > java.lang.IllegalStateException: Your JVM is not releasing > SoftReference, try running the testcase with less memory (-Xmx) > at > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase.forceGarbageCollection(MemoryLeakTestCase.java:496) > at > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase.testMethodUtils_cache_memoryLeak(MemoryLeakTestCase.java:282) > > This does not look like a blocker though. This test is indeed tricky. In the configuration of the surefire plug-in the maximum memory size is decreased to 25m to force the garbage collector to get active, but obviously this does not work in a reliable way. The problem does not occur in my environment. And, to my defense, I can say that this test has not been touched since the last release. > > Environment: > > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 > 17:22:22+0200) > Maven home: /home/tn/bin/apache-maven-3.1.1 > Java version: 1.7.0_25, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-7-openjdk-i386/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.2.0-56-generic-pae", arch: "i386", family: > "unix" > > According to the issue tracker there are currently 3 blocker and 6 > critical issues which are targeted for 2.0. After looking at them, I > would suggest to better target for a 1.9.1 release specifically > resolving these issues, as I understand that the main purpose of 1.9 is > to introduce generics. Good point. However, I fear that the interest in [beanutils] 1.x is pretty low, so I doubt that there will be much activity in this area in the near future. Oliver > > The rest looks fine, the release notes are very clear! (and look better > than the ones I have generated so far ;-) > > +1 > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
