On 11/20/2013 07:16 PM, Thomas Neidhart wrote: > On 11/20/2013 05:43 PM, Renato Cherullo wrote: >> Ok, I just pushed my code to the fork at >> https://github.com/cherullo/commons-math. >> Merging with SolutionCallback was straightforward, and the standard tests >> passed. >> I already saw issues in the new code, but right now I'd like your opinion >> on the current interface (ie. public SimplexSolution >> optimizeExtra(OptimizationData...)). >> It doesn't seem to fit well with the rest. Thoughts? > > I think you committed a bit too much - try to remove the target directory.
Sorry, I missed that you already cleaned up the codebase after the first commit. Regarding the additional optimize method: I think this would also be acceptable to add such a method as additional information about this specific optimization algorithm is returned, which is not available for others. The actual interface and data returned needs to be further discussed, and unit tests will be necessary, but take your time and continue with your approach. Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
