Hi Gary, thanks for your review and all the changes. Would you mind updating the checkstyle configuration with your local settings if possible, so that everybody working on the project has the same baseline for warnings/errors.
I mainly focus on these warnings (enabled checkstyle plugin) together with the default ones from eclipse and try to have a clean project all the time. Thanks, Thomas On Wed, Nov 20, 2013 at 3:39 PM, Gary Gregory <garydgreg...@gmail.com>wrote: > +1 > > Note that I've made a lot of polish commits over the last three days after > reviewing various reports and IDE warnings; these would be nice to have in > a major release like 4.0 but they are not blockers. > > Tested with: > > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 > 11:22:22-0400) > Maven home: C:\Java\apache-maven-3.1.1\bin\.. > Java version: 1.7.0_45, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_45\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > Gary > > > On Sun, Nov 17, 2013 at 2:22 PM, Thomas Neidhart > <thomas.neidh...@gmail.com>wrote: > > > Hi, > > > > I'd like to call a vote for releasing Commons Collections 4.0 based on > > RC4 and I am quite confident with this RC after all the valuable > > feedback from the previous RCs has been integrated. > > > > Changes since RC3: > > > > * [COLLECTIONS-501] Renamed methods "V MultiKeyMap#remove(Object, > > Object, ...)" to "V MultiKeyMap#removeMultiKey(Object, Object, > > ...)" to avoid future conflicts with a default method of the Map > > interface in Java 8. > > * [COLLECTIONS-500] Renamed "V MultiMap#remove(K, V)" to "boolean > > MultiMap#removeMapping(K, V)" to avoid future conflicts with a > > default method of the Map interface in Java 8. > > * fixed compilation problem with IBM JDK 5 > > * fixed test failures with IBM JDK 6 by disabling some of them in > > case the tests are executed with such a JDK > > * added note to the release notes (textual version) wrt disabled tests > > > > Changes since RC2: > > > > * [COLLECTIONS-499] Refactored the test framework for Bag > > implementations to extend from "AbstractCollectionTest" by > > decorating the concrete Bag instance with a CollectionBag or > > CollectionSortedBag. > > * [COLLECTIONS-498] "CollectionBag" will now also respect the > > contract of the decorated bag in case a null argument is provided > > to either removeAll or retainAll. > > * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which > > decorates a SortedBag to make it comply with the Collection > > contract. > > * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also > > implement the marker interface "Unmodifiable" similar as all other > > unmodifiable decorators. > > * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will > > not decorate again an already unmodifiable Trie. Also the return > > type has been changed to "Trie" to be consistent with other > > Unmodifiable decorators. > > * [COLLECTIONS-494] Moved "Equator" interface to base package for > > consistency. Thanks to Emmanuel Bourg. > > * improved release notes with suggestions from Emmanuel Bourg > > * added unit tests for TrieUtils and QueueUtils and factory methods > > for all Unmodifiable decorators > > * added more unit tests for the Queue interface > > * cleanup of many test classes: removed unused imports, unneeded > > constructors > > > > Changes since RC1: > > > > * release notes are now also included in the binary distribution > > * removed spurious hashCode() method in AbstractPatriciaTrie, the > > inherited one from AbstractMap will be used instead > > > > > > Collections 4.0 RC4 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/collections/ > > (svn revision 3546) > > > > Maven artifacts are here: > > > > > > > https://repository.apache.org/content/repositories/orgapachecommons-148/org/apache/commons/commons-collections4/4.0/ > > > > The tag is here: > > > > > > > https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC4/ > > (svn revision 1542797) > > > > Site: > > http://people.apache.org/builds/commons/collections/4.0/RC4/ > > > > Details of changes can be found in the release notes: > > > > > > > https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt > > > > > http://people.apache.org/builds/commons/collections/4.0/RC4/changes-report.html > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Note: the clirr report is generated against 4.0-alpha1 and it is also > > highlighted in the release notes that this release is not compatible > > with any previous release. > > > > Thank you for your reviews, > > > > Thomas > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition< > http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory >
