org.apache.commons.compress.archivers.ar.ArArchiveInputStream#getNextArEntry()
The code to "skip to the next available entry" looks a bit inefficient because it reads one byte at a time in a loop. Consider using org.apache.commons.compress.utils.IOUtils.skip(InputStream, long) Consider using org.apache.commons.compress.utils.IOUtils.readFully(InputStream, byte[], int, int) on line 98 or else there may be an unnecessary exception thrown. In fact, everywhere there is a read for header information, consider using "readFully". Right now, lines 118-124 are not doing readFully and the return value is not being checked. On Mon, Oct 14, 2013 at 12:17 AM, Stefan Bodewig <bode...@apache.org> wrote: > I think enough issues have been identified to warrant a second RC. > > I'll take care of the bad version number in the release notes as well as > the PMD warnings in the ARJ-Package. ArjArchiveEntry's test coverage > has already been increased in trunk. > > We should talk about the Clirr report further and come to a conclusion > what to do about the changes - if anything at all. > > For the site's contents I don't see myself working on it before a second > RC. Help is more than welcome (not only with the site, of course). > > Thanks to all who took the time to review the RC > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
