Thanks
2013/8/3 <s...@apache.org> > Author: sebb > Date: Sat Aug 3 11:59:28 2013 > New Revision: 1509967 > > URL: http://svn.apache.org/r1509967 > Log: > Fix up TODOs > > Modified: > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > > Modified: > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > URL: > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java?rev=1509967&r1=1509966&r2=1509967&view=diff > > ============================================================================== > --- > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > (original) > +++ > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > Sat Aug 3 11:59:28 2013 > @@ -324,37 +324,37 @@ public class CSVLexerTest { > assertThat(lexer.nextToken(new Token()), > hasContent("NotEscaped")); > } > > - @Test // TODO is this correct? Do we expect TAB to be un/escaped? > + @Test // TODO is this correct? Do we expect <esc>TAB to be unescaped? > public void testEscapedTab() throws Exception { > final Lexer lexer = getLexer("character\\" + TAB + "Escaped", > formatWithEscaping); > assertThat(lexer.nextToken(new Token()), hasContent("character" + > TAB + "Escaped")); > } > > - @Test // TODO is this correct? Do we expect TAB to be un/escaped? > + @Test > public void testTab() throws Exception { > final Lexer lexer = getLexer("character" + TAB + "NotEscaped", > formatWithEscaping); > assertThat(lexer.nextToken(new Token()), hasContent("character" + > TAB + "NotEscaped")); > } > > - @Test // TODO is this correct? Do we expect BACKSPACE to be > un/escaped? > + @Test // TODO is this correct? Do we expect <esc>BACKSPACE to be > unescaped? > public void testEscapedBackspace() throws Exception { > final Lexer lexer = getLexer("character\\" + BACKSPACE + > "Escaped", formatWithEscaping); > assertThat(lexer.nextToken(new Token()), hasContent("character" + > BACKSPACE + "Escaped")); > } > > - @Test // TODO is this correct? Do we expect BACKSPACE to be > un/escaped? > + @Test > public void testBackspace() throws Exception { > final Lexer lexer = getLexer("character" + BACKSPACE + > "NotEscaped", formatWithEscaping); > assertThat(lexer.nextToken(new Token()), hasContent("character" + > BACKSPACE + "NotEscaped")); > } > > - @Test // TODO is this correct? Do we expect FF to be un/escaped? > + @Test // TODO is this correct? Do we expect <esc>FF to be unescaped? > public void testEscapedFF() throws Exception { > final Lexer lexer = getLexer("character\\" + FF + "Escaped", > formatWithEscaping); > assertThat(lexer.nextToken(new Token()), hasContent("character" + > FF + "Escaped")); > } > > - @Test // TODO is this correct? Do we expect FF to be un/escaped? > + @Test > public void testFF() throws Exception { > final Lexer lexer = getLexer("character" + FF + "NotEscaped", > formatWithEscaping); > assertThat(lexer.nextToken(new Token()), hasContent("character" + > FF + "NotEscaped")); > > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
