On Tue, Jul 30, 2013 at 5:47 PM, Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 30/07/2013 23:24, Gary Gregory a écrit : > > > Yeah, that's too clever IMO. I expected the same behavior WRT record > > reading with the only difference being if I let the parser guess or not. > > Too clever? I didn't feel like I designed a rocket with this feature > though :) That's an important feature to me and I'd like to preserve it. > > If the header is defined in the file I don't want to skip the first > record manually, the parser should take care of it. That also means the > user code can remain the same, whether the header is defined in the code > or in the file. > Let me reply to this part tomorrow (it's late here ;) > > > > The current code now always reads the header line if you set any non-null > > header. If you call withHeader() with no args it is a non-null call with > an > > empty String[]. > > I guess a null header or an empty header is just the same and means the > first record must be used as the header. > It is not the same at all. A null header String[] is different from a length 0 array. It's been like that for a while. Gary > > Emmanuel Bourg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
