On 6 May 2013 23:32, Jörg Schaible <joerg.schai...@gmx.de> wrote: > > -1 > > The test for this constructor showed, that you could use an own implementation > for the last parameter. Providing a DefaultExceptionContext makes no > difference to providing null (as it is done implicitly by the other > constructors). >
When fixed, this needs to be clearly documented in the test code please. > --------------- Weitergeleitete Nachricht (Anfang) > > Betreff: svn commit: r1479663 - > /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java > Absender: britter-1odqgaof3lkdnm+yrof...@public.gmane.org > Datum: Mon, 06 May 2013 18:05:38 +0000 > Newsgruppe: gmane.comp.jakarta.commons.scm > > Author: britter > Date: Mon May 6 18:05:37 2013 > New Revision: 1479663 > > URL: http://svn.apache.org/r1479663 > Log: > No need to define an anonymous subclass here > > Modified: > > commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java > > Modified: > commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java > URL: > http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java?rev=1479663&r1=1479662&r2=1479663&view=diff > ============================================================================== > --- > commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java > (original) > +++ > commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ContextedRuntimeExceptionTest.java > Mon May 6 18:05:37 2013 > @@ -79,7 +79,7 @@ public class ContextedRuntimeExceptionTe > > @Test > public void testContextedExceptionStringThrowableContext() { > - exceptionContext = new ContextedRuntimeException(TEST_MESSAGE_2, new > Exception(TEST_MESSAGE), new DefaultExceptionContext() {}); > + exceptionContext = new ContextedRuntimeException(TEST_MESSAGE_2, new > Exception(TEST_MESSAGE), new DefaultExceptionContext()); > final String message = exceptionContext.getMessage(); > final String trace = ExceptionUtils.getStackTrace(exceptionContext); > assertTrue(trace.indexOf("ContextedException")>=0); > > > > --------------- Weitergeleitete Nachricht (Ende) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
