On Mon, Apr 8, 2013 at 4:35 PM, Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 07/04/2013 20:14, Benedikt Ritter a écrit :
>
> > where are we standing with this? I see that Gary has added parse(Reader)
> to
> > the Builder as a short cut. We were talking about making the builder less
> > visible. How do you feel about renaming the newBuilder() methods to
> > newFormat()?
>
> Sure why not, but that's not enough in my opinion.
>
> I used to be able to write this:
>
> fmt = CSVFormat.DEFAULT.withDelimiter('!');
>
> and now I have to write this:
>
> fmt = CSVFormat.newBuilder().withDelimiter('!').build()
>
Right, I just wrote:
final CSVPrinter printer = new CSVPrinter(sw,
CSVFormat.DEFAULT.toBuilder().withNullToString("NULL").build());
Yikes! But that's the price for immutability for some of these objects.
Adding shortcuts would bloat the code:
CSVFormat.DEFAULT.buildWithNullToString("NULL");
I'd need a buildWith method for each format option. Do-able but not great.
Gary
>
> That's much longer :(
>
>
> Emmanuel Bourg
>
>
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
