2013/3/20 Christian Grobmeier <grobme...@gmail.com>

> On Wed, Mar 20, 2013 at 8:53 PM, Benedikt Ritter <brit...@apache.org>
> wrote:
> >> +    /**
> >> +     * Returns an iterator over the values of this record.
> >> +     *
> >> +     * @return an iterator over the values of this record.
> >> +     */
> >>
> >
> > I had no better idea how to comment this. Any suggestions how to make
> this
> > less redundant?
>
> If you ask me, delete it. A method called iterator() is already docs
> enough.
>

Iterable<T>.iterator() doc is:

"Returns an iterator over a set of elements of type T."

I thought it would be nice to tweak this a bit to match a CSVRecord. But
you're right every programmer should know what a iterator is and does.


>
> BTW, I love this post from our fellow Torsten Curdt, who is not often
> seen here (unfortunately):
> http://vafer.org/blog/20050323095453/


Unfortunately I haven't seen commits for commons from you in a long time
either ;-)


>
>
> I know people want it because of checkstyle, but actually this docs
> are not giving me anything.
>
>
>
> --
> http://www.grobmeier.de
> https://www.timeandbill.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to