>> /** >> + * The default number of byte shift for decode. >> + */ >> + private static final int OUT_SHIFT = 4; >> + > > The Javadoc needs to say why the value 4 is used, otherwise it's still > a magic number. >
it is even part of black magic if you take in consideration that is it a private field of a package-protected class used for internal-use only http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org