OK, sounds like a respin then? Gary
On Tue, Feb 26, 2013 at 3:04 PM, Thomas Neidhart <thomas.neidh...@gmail.com>wrote: > On 02/25/2013 11:59 PM, Jörg Schaible wrote: > > Hi Thomas, > > > > Thomas Neidhart wrote: > > > >> Hi, > >> > >> I'd like to call a vote for releasing Commons Email 1.3.1 based on RC2. > >> > >> This release candidate has the following changes compared to RC1: > >> > >> * Clirr compares now to 1.3 rather than 1.2 > >> * Link to released API has been fixed > >> > >> The files: > >> > >> The artifacts are deployed to Nexus: > >> > > > https://repository.apache.org/content/repositories/orgapachecommons-298/org/apache/commons/commons- > > email/1.3.1/ > >> > >> The tag: > >> > > > https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_1_RC2/ > >> > >> The site: > >> http://people.apache.org/builds/commons/email/1.3.1/RC2/ > >> > >> Additional Notes: > >> > >> o the download page and api links to older releases only work on > >> the published site and will be corrected after release. > >> > >> Please take a look at the commons-email-1.3.1 artifacts and vote! > >> > >> ------------------------------------------------ > >> [ ] +1 release it. > >> [ ] +0 go ahead; I don't care. > >> [ ] -0 there are a few minor glitches: ... > >> [ ] -1 no, do not release it because ... > >> ------------------------------------------------ > >> > >> Vote will remain open for at least 72 hours. > > > > I tried to rebuild the project from the -src.tar.gz package, running > M304 on > > Gentoo Linux/64. For Oracle JDK 5 to 7 and for the icedtea 6+7 JDKs I > have a > > lot of these console outputs while running the tests (e.g. HtmlMailTest): > > > > ================ %< ================= > > Running org.apache.commons.mail.HtmlEmailTest > > SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". > > SLF4J: Defaulting to no-operation (NOP) logger implementation > > SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for > further > > details. > > SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder". > > SLF4J: Defaulting to no-operation MDCAdapter implementation. > > SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for > further > > details. > > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.075 > sec > > ================ %< ================= > > > > Seems like we're missing a test dependency to a real slf4j > implementation. > > > > However, it is really worse with the IBM JDK 5+6 where I have 67 failing > > tests for each JDK. More or less all of those look like: > > > > ================ %< ================= > > testEmbedFileWithCID(org.apache.commons.mail.ImageHtmlEmailTest) Time > > elapsed: 0.006 sec <<< ERROR! > > java.lang.NoClassDefFoundError: org.subethamail.wiser.Wiser > (initialization > > failure) > > at java.lang.J9VMInternals.initialize(J9VMInternals.java:140) > > at java.lang.Class.forNameImpl(Native Method) > > at java.lang.Class.forName(Class.java:139) > > at javassist.runtime.Desc.getClassObject(Desc.java:43) > > at javassist.runtime.Desc.getClassType(Desc.java:136) > > at javassist.runtime.Desc.getType(Desc.java:122) > > at javassist.runtime.Desc.getType(Desc.java:78) > > at > > > org.apache.commons.mail.BaseEmailTestCase.tearDown(BaseEmailTestCase.java:127) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60) > > at > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37) > > at java.lang.reflect.Method.invoke(Method.java:611) > > at > > > org.powermock.reflect.internal.WhiteboxImpl.performMethodInvocation(WhiteboxImpl.java:2014) > > at > > > org.powermock.reflect.internal.WhiteboxImpl.doInvokeMethod(WhiteboxImpl.java:885) > > at > > > org.powermock.reflect.internal.WhiteboxImpl.invokeMethod(WhiteboxImpl.java:713) > > at org.powermock.reflect.Whitebox.invokeMethod(Whitebox.java:401) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:323) > > at > > org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:88) > > at > > > org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:296) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:112) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:73) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:284) > > at > > org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:86) > > at > org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:209) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:148) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:122) > > at > > > org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:33) > > at > > org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:45) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:120) > > at > > > org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:102) > > at > > > org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53) > > at > > org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:42) > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60) > > at > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37) > > at java.lang.reflect.Method.invoke(Method.java:611) > > at > > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:208) > > at > > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:158) > > at > > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:86) > > at > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > > at > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:95) > > > > testHtmlMailMimeLayout(org.apache.commons.mail.ImageHtmlEmailTest) Time > > elapsed: 0.073 sec <<< ERROR! > > java.lang.NoClassDefFoundError: org.subethamail.wiser.Wiser > (initialization > > failure) > > at java.lang.J9VMInternals.initialize(J9VMInternals.java:140) > > at java.lang.Class.forNameImpl(Native Method) > > at java.lang.Class.forName(Class.java:139) > > at javassist.runtime.Desc.getClassObject(Desc.java:43) > > at javassist.runtime.Desc.getClassType(Desc.java:136) > > at javassist.runtime.Desc.getType(Desc.java:122) > > at javassist.runtime.Desc.getType(Desc.java:78) > > at > > > org.apache.commons.mail.BaseEmailTestCase.tearDown(BaseEmailTestCase.java:127) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60) > > at > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37) > > at java.lang.reflect.Method.invoke(Method.java:611) > > at > > > org.powermock.reflect.internal.WhiteboxImpl.performMethodInvocation(WhiteboxImpl.java:2014) > > at > > > org.powermock.reflect.internal.WhiteboxImpl.doInvokeMethod(WhiteboxImpl.java:885) > > at > > > org.powermock.reflect.internal.WhiteboxImpl.invokeMethod(WhiteboxImpl.java:713) > > at org.powermock.reflect.Whitebox.invokeMethod(Whitebox.java:401) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:323) > > at > > org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:88) > > at > > > org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:296) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:112) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:73) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:284) > > at > > org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:86) > > at > org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:209) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:148) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:122) > > at > > > org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:33) > > at > > org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:45) > > at > > > org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:120) > > at > > > org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:102) > > at > > > org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53) > > at > > org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:42) > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60) > > at > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37) > > at java.lang.reflect.Method.invoke(Method.java:611) > > at > > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:208) > > at > > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:158) > > at > > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:86) > > at > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > > at > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:95) > > ================ %< ================= > > > > I don't know what this powermock/javaassist combo does, but either it > seems > > to fail completely for IBM JDK or it is the Wiser class itself that > fails to > > initialize on these JDKs. > > > > I've tested therefore also against 1.3 and the situation is the same, so > it > > is not a real regression now (unfortunately, I had no time to test the > 1.3 > > release). Since this is currently a bug fix release, I will vote with -0 > for > > now, but for 1.4 it would have been -1. > > Just tested it now myself with IBM JDK 6: > > IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32 > jvmxi3260sr12-20121024_126067 (JIT enabled, AOT enabled) > > Tests run: 149, Failures: 0, Errors: 67, Skipped: 0 > > when I add an actual slf4j binding: > > + <dependency> > + <groupId>org.slf4j</groupId> > + <artifactId>slf4j-jdk14</artifactId> > + <version>1.7.2</version> > + <scope>test</scope> > + </dependency> > > Tests run: 134, Failures: 0, Errors: 0, Skipped: 0 > > I always overlooked to add an slf4j binding, because it was never > needed, but it can have quite negative side-effect ;-). > > Weird, > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory