On 12/14/12 3:14 PM, Gilles Sadowski wrote: > On Fri, Dec 14, 2012 at 09:47:25AM -0800, Phil Steitz wrote: >> On 12/14/12 7:50 AM, Gilles Sadowski wrote: >>> On Fri, Dec 14, 2012 at 07:38:13AM -0800, Phil Steitz wrote: >>>> On 12/12/12 11:37 AM, Gary Gregory wrote: >>>>> Make sure you have all of your Checkstyle, FindBugs, and PMD ducks in a >>>>> row >>>>> ;) >>>> One more thing to check is @since tags for new methods. I saw I >>>> missed a few. >>> Is that a release blocker? >> I would say yes. I will work on this tonight using the Clirr report >> to check. > [I don't remember that it was considered a blocker (a possible doc > improvement, yes; a bug, no).]
It is pretty much a Commons standard to make sure @since tags are correct in releases. > > A RC1 could be released anytime now, if not for this. And I do not think > that other people are going to check for possibly missing "@since" tags > in the next few hours. > Since you wish to perform those additional changes; let's say that I'll wait > for another 12 hours, after which I'll try to create RC1. OK? I am about halfway done. I just committed fixes about halfway through the linear package. I will pick this back up tomorrow AM (Pacific). The last class I reviewed was JacobiPreconditioner. Phil > > > Gilles > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
