On Mon, Oct 22, 2012 at 4:20 AM, Gilles Sadowski < gil...@harfang.homelinux.org> wrote:
> On Sun, Oct 21, 2012 at 11:25:08PM -0700, Ted Dunning wrote: > > What kind of check did you want? > > Well, I'm seeking to know whether the code can be included in Commons > Math's > trunk. > Hard for me to say as I am usually out of step with c.m. > Currently, the answer is a partial "no" (IMHO), because of the remarks > which > I formulated on the JIRA page. [If it were only that, I would have corrected the formatting problems (to my > taste).] > Fair. > Thus: I'd like people to confirm that the code itself fits with the design > of the "o.a.c.m.stat" package, and to take the responsibility for > committing > the patch (adapted to their taste!). :-) > I can't comment on the design. Only on whether it seems to do what it says it should. > > > I checked the code by eye and supplied several test cases. You might say > > that I am versed in statistics since I am the author of the major paper > on > > this test as applied to computational linguistics. > > Thank you for the _contents_ review. Sorry for the misunderstanding that I > was talking more about the form. > I can't comment on the form.
