On 10/9/12 10:55 AM, Peter Andrews wrote: > Thank you. > > I created a jira account and looked at the submission > <https://issues.apache.org/jira/browse/MATH-877>. Thank you for > doing that. > > Minor note: category in title of ticket is misspelled catagory.
Thanks! Phil > > Thanks, > > Peter > > On 10/9/2012 11:25 AM, Phil Steitz wrote: >> Thanks for your contribution and your kind words below. Its always >> best to attach patches to JIRA tickets so they don't get lost in the >> din of the mailing list. Should you contribute more in the future - >> which you are certainly encouraged to do - its really no more work >> to just open a JIRA [1] and attach your code to the ticket. I just >> opened MATH-877 to track this issue. >> >> Thanks again. >> >> Phil >> >> [1] http://commons.apache.org/math/developers.html (Getting Started >> section) >> >> On 10/9/12 7:21 AM, Peter Andrews wrote: >>> I have implemented a version of OneWayAnova which uses >>> SummaryStatistics rather than requiring the array of doubles. >>> >>> I know that there is a whole process for submitting code but I am >>> under a deadline so sending this email with the code is all I am >>> going to do. >>> >>> A couple of notes: >>> >>> 1. I would have maintained the same signature structure simply >>> adding methods that supported Collection<SummaryStatistics> >>> but that creates an error because it has the same Signature >>> due to type erasure on Collection<double[]>. >>> >>> 1. I did not see why certain cases such as having only one array >>> or number of elements < 2 should necessarily throw exceptions >>> -- the math still works out and gives reasonable results so >>> given point #1, I differentiated the function signatures by >>> adding a boolean to optionally skip the checks and therefore >>> not not throw DimensionMismatchException. >>> >>> Minor note: I understand that you cannot change it at this point >>> but there is no reason for this class not to abstract with static >>> methods since it has no state. >>> >>> Do with this what you will. >>> >>> Thanks for the wonderful tools you provide. >>> >>> Peter Andrews >>> >>> >>> >>> --------------------------------------------------------------------- >>> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
