On Fri, Sep 28, 2012 at 1:47 PM, Jörg Schaible <joerg.schai...@gmx.de>wrote:
> sebb wrote: > > > On 28 September 2012 08:17, Jörg Schaible <joerg.schai...@scalaris.com> > > wrote: > >> Hi Sebb, > >> > >> sebb wrote: > >> > >>> On 27 September 2012 23:53, <joe...@apache.org> wrote: > >>>> Author: joehni > >>>> Date: Thu Sep 27 22:53:46 2012 > >>>> New Revision: 1391258 > >>>> > >>>> URL: http://svn.apache.org/viewvc?rev=1391258&view=rev > >>>> Log: > >>>> Use conversion tables for boolean arrays. > >>> > >>> I think the previous code was much clearer. > >>> > >>> At first sight it now looks as though the static arrays are shared > >>> (which would not be safe) but in fact they are cloned. > >> > >> At least I should have checked it with a profiler before. Don't we have > a > >> YourKit license for Apache somewhere? > > > > Is a hoped for performance gain why you made the change? > > > > Unless there is a significant improvement across several Java > > versions, I'm -1 on the change as the code is now more obscure. > > Done. > > Any comment on replacing the standard hex representation (i.e. lower case > letters like JDK does)? While semantically the same, I wonder if changing the output style will surprise some users. I'm 50/50. > Or further usage of JDK functionality? > I think it has to be considered on a case by case basis if there are any side-effects like the one above. Gary > > - Jörg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
