On Tue, Sep 18, 2012 at 07:45:24AM +0200, Sébastien Brisard wrote: > Hi, > I'd like to make a move on this issue. Does everyone agree with what's > already written in this ticket (not much, I'm afraid). > Does anyone want to add anything to the formatting section? This > should be something we are particularly attached to, and that can't be > revealed by the checkstyle report. > > Also, we could add some guidance on coding practices (prefer final > over non final variables/fields, and so on).
Yes, certainly: * "final" must be used when the value of the variable will not change. * Variables should not be deprived of the "final" keyword just so that they be "recycled" (i.e. use different variables when they mean different things). [Again, "BOBYQAOptimizer" was a "nice" example of not following that latter rule.] > > Any ideas? I've updated the JIRA ticket with my preferences. Thanks for advancing this issue, Gilles > > Thanks in advance, > Sébastien > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
