On 9 September 2012 01:56, Gary Gregory <garydgreg...@gmail.com> wrote: > Hi All: > > @Sebb: Didn't you do the re-write of the BaseN code? If so, can you address > the couple of missing default clause issues reported by FindBugs?
Yes, I did do some refactoring, but I don't think that involved the switch statements directly. However, I've added what appears to be necessary extra cases and defaults. There is one case which is not exercised by tests, so I added a TODO. We need more tests... > Unless someone else kicks in the effort that is :) > > We [all] discussed this recently and the consensus seems to be to add > default clauses with documentation or a throws statement. > > I took a peek and there is some subtle behavior going on there especially > regarding the modulus field. I'd rather have the original author provide > this change. > > Thank you, > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
