On Sat, Sep 08, 2012 at 10:50:29AM +0300, marios michaelidis wrote: > > Hi everyone, > I will start with the tolerance and Vif checks, because it is smaller and I > want to get familiar with the system. I have created a relevant ticket > labelled as " > I would like to include a VIF and TOLERANCE check for a 2 dimensional double > array, vey commonly used by major packages to determine variables that cause > multi-colinearity issues and should be excluded from the models" > Shall I just upload the class?
If you think that all design issues are clear, and you are ready to adapt your code for inclusion to Commons Math (or have done so already), then yes, you could just attach your proposed code to the issue on the bug-tracking system. If you want to discuss design issues (such as how to best adapt your code), it is better to ask specific questions on this ML. > What else do I need to do? It depends on where you are in the process... Did you already check out the CM source code? Did you include your contribution in your working copy of CM? Does it follow the style used in CM (API and formatting)? Does it compile? Did you write unit tests that cover all functionalities? Do they pass? Best regards, Gilles > Regards > Marios > > From: ted.dunn...@gmail.com > > Date: Fri, 7 Sep 2012 16:09:34 -0700 > > Subject: Re: [math] Logistic, Probit regerssion and Tolerance checks > > To: dev@commons.apache.org > > > > On Fri, Sep 7, 2012 at 4:06 PM, Phil Steitz <phil.ste...@gmail.com> wrote: > > > > > On 9/7/12 3:28 PM, Ted Dunning wrote: > > > >> Patches welcome! > > > >> > > > > Would normally love to, but I can't do more than kibitz based on other > > > > implementations I have done. > > > > > > > OK, lets start with what Marios has and see where we can take it. > > > > > > > > Cool. > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
