This is really a shortcoming in FB IMO :( Gary
On Sep 3, 2012, at 14:48, sebb <seb...@gmail.com> wrote: > On 3 September 2012 19:37, <t...@apache.org> wrote: >> Author: tn >> Date: Mon Sep 3 18:37:21 2012 >> New Revision: 1380305 >> >> URL: http://svn.apache.org/viewvc?rev=1380305&view=rev >> Log: >> Fixed findbugs warning wrt unused imports resulting from javadoc types. > > Another way to fix this would be to add the exceptions to the throws > clause; then the import would not be redundant (and the Javadoc would > be a bit shorter). > > But not necessary to change this here; perhaps consider for other cases? > >> Modified: >> >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java >> >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java >> >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java >> >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java >> >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java >> >> Modified: >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java?rev=1380305&r1=1380304&r2=1380305&view=diff >> ============================================================================== >> --- >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java >> (original) >> +++ >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/Charsets.java >> Mon Sep 3 18:37:21 2012 >> @@ -17,7 +17,6 @@ >> package org.apache.commons.codec; >> >> import java.nio.charset.Charset; >> -import java.nio.charset.UnsupportedCharsetException; >> >> /** >> * Charsets required of every implementation of the Java platform. >> @@ -81,7 +80,7 @@ public class Charsets { >> * @param charset >> * The name of the requested charset, may be null. >> * @return a Charset for the named charset >> - * @throws UnsupportedCharsetException >> + * @throws java.nio.charset.UnsupportedCharsetException >> * If the named charset is unavailable >> */ >> public static Charset toCharset(String charset) { >> >> Modified: >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java?rev=1380305&r1=1380304&r2=1380305&view=diff >> ============================================================================== >> --- >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java >> (original) >> +++ >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Hex.java >> Mon Sep 3 18:37:21 2012 >> @@ -18,7 +18,6 @@ >> package org.apache.commons.codec.binary; >> >> import java.nio.charset.Charset; >> -import java.nio.charset.UnsupportedCharsetException; >> >> import org.apache.commons.codec.BinaryDecoder; >> import org.apache.commons.codec.BinaryEncoder; >> @@ -207,7 +206,7 @@ public class Hex implements BinaryEncode >> * >> * @param charsetName >> * the charset name. >> - * @throws UnsupportedCharsetException >> + * @throws java.nio.charset.UnsupportedCharsetException >> * If the named charset is unavailable >> * @since 1.4 >> * @since 1.7 throws UnsupportedCharsetException if the named charset is >> unavailable >> >> Modified: >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java?rev=1380305&r1=1380304&r2=1380305&view=diff >> ============================================================================== >> --- >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java >> (original) >> +++ >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/BCodec.java >> Mon Sep 3 18:37:21 2012 >> @@ -19,7 +19,6 @@ package org.apache.commons.codec.net; >> >> import java.io.UnsupportedEncodingException; >> import java.nio.charset.Charset; >> -import java.nio.charset.UnsupportedCharsetException; >> >> import org.apache.commons.codec.Charsets; >> import org.apache.commons.codec.DecoderException; >> @@ -75,7 +74,7 @@ public class BCodec extends RFC1522Codec >> * >> * @param charsetName >> * the default charset to use. >> - * @throws UnsupportedCharsetException >> + * @throws java.nio.charset.UnsupportedCharsetException >> * If the named charset is unavailable >> * @since 1.7 throws UnsupportedCharsetException if the named charset is >> unavailable >> * @see <a >> href="http://download.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard >> charsets</a> >> >> Modified: >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java?rev=1380305&r1=1380304&r2=1380305&view=diff >> ============================================================================== >> --- >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java >> (original) >> +++ >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QCodec.java >> Mon Sep 3 18:37:21 2012 >> @@ -19,7 +19,6 @@ package org.apache.commons.codec.net; >> >> import java.io.UnsupportedEncodingException; >> import java.nio.charset.Charset; >> -import java.nio.charset.UnsupportedCharsetException; >> import java.util.BitSet; >> >> import org.apache.commons.codec.Charsets; >> @@ -136,7 +135,7 @@ public class QCodec extends RFC1522Codec >> * >> * @param charsetName >> * the charset to use. >> - * @throws UnsupportedCharsetException >> + * @throws java.nio.charset.UnsupportedCharsetException >> * If the named charset is unavailable >> * @since 1.7 throws UnsupportedCharsetException if the named charset is >> unavailable >> * @see <a >> href="http://download.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html">Standard >> charsets</a> >> >> Modified: >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java?rev=1380305&r1=1380304&r2=1380305&view=diff >> ============================================================================== >> --- >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java >> (original) >> +++ >> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java >> Mon Sep 3 18:37:21 2012 >> @@ -20,7 +20,6 @@ package org.apache.commons.codec.net; >> import java.io.ByteArrayOutputStream; >> import java.io.UnsupportedEncodingException; >> import java.nio.charset.Charset; >> -import java.nio.charset.UnsupportedCharsetException; >> import java.util.BitSet; >> >> import org.apache.commons.codec.BinaryDecoder; >> @@ -111,7 +110,7 @@ public class QuotedPrintableCodec implem >> * >> * @param charsetName >> * the default string charset to use. >> - * @throws UnsupportedCharsetException >> + * @throws java.nio.charset.UnsupportedCharsetException >> * If the named charset is unavailable >> * @since 1.7 throws UnsupportedCharsetException if the named charset is >> unavailable >> */ >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org