Hi Luc, 2012/9/1 Luc Maisonobe <luc.maison...@free.fr>: > Le 01/09/2012 10:03, Sébastien Brisard a écrit : >> Hi, >> >> in ConjugateGradient, I get the following error >> >> "Exception NonPositiveDefiniteOperatorException is not compatible with >> throws clause in >> PreconditionedIterativeLinearSolver.solveInPlace(RealLinearOperator, >> RealLinearOperator, RealVector, RealVector)" >> >> This comes from the fact that general iterative solvers do not require >> positive definite operators (therefore, no >> "throws NonPositiveDefiniteOperatorException" clause in the signature of >> PreconditionedIterativeLinearSolver.solveInPlace), while conjugate >> gradient does. >> >> Do I need to add the "throws NonPositiveDefiniteOperatorException" >> clause in the signature of >> PreconditionedIterativeLinearSolver.solveInPlace as well? > > I think so, as users may use a ConjugateGradient and store it in a > variable declared with the base class only. However, I don't know if > adding an unchecked exception to the signature of an interface is a > compatible change or not. > > Luc > clirr does not seem to be complaining, so I'll do as you say. Here is what I'm planning to add to the javadoc of the mother abstract class. What do you think?
* @throws NonPositiveDefiniteOperatorException if {@code a} or {@code m} * is not positive definite (required by some iterative solvers) Sébastien >> >> Sébastien >> >> 2012/9/1 Sébastien Brisard <sebastien.bris...@m4x.org>: >>> Hello, >>> >>> >>> 2012/8/31 Thomas Neidhart <thomas.neidh...@gmail.com>: >>>> On 08/31/2012 11:17 AM, Luc Maisonobe wrote: >>>>> Le 31/08/2012 03:22, Sébastien Brisard a écrit : >>>>>> Hello, >>>>>> >>>>>>>>>> [...] >>>>>>>>>> >>>>>>>>>> Thus, shall I open a JIRA ticket with the tasks of completing the >>>>>>>>>> "throws" >>>>>>>>>> clauses of all CM methods? >>>>>>>>>> Does someone absolutely needs this task tobe completed before >>>>>>>>>> releasing 3.1? >>>>>>>>>> [I don't think that it's possible without a huge effort from >>>>>>>>>> everyone.] >>>>>>>> >>>>>>>> Ticket created: >>>>>>>> https://issues.apache.org/jira/browse/MATH-854 >>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> No hurry on my side, but I'm happy contributing. In order not to tread >>>>>>>>> on anyone's feet, maybe each of us should be assigned one package (for >>>>>>>>> a start). >>>>>>>> >>>>>>>> Good idea. >>>>>>>> >>>>>>>> Gilles: packages "o.a.c.m.optimization" >>>>>>>> "o.a.c.m.analysis.function" >>>>>>>> "o.a.c.m.analysis.solvers" >>>>>>>> "o.a.c.m.analysis.integration" >>>>>>>> "o.a.c.m.analysis.interpolation" >>>>>>> >>>>>>> +1 to divide and conquer. I will start on stat. >>>>>>> >>>>>>> Phil >>>>>>>> >>>>>>>> >>>>>>>> Best regards, >>>>>>>> Gilles >>>>>>>> >>>>>> I can take care of linear and special, of course! >>>>> >>>>> I'll look at ode, differentiation and geometry. >>>> >>>> I will start with filter and genetics. >>>> >>>> Thomas >>>> >>> Just to make sure I don't forget anything... We must apply >>> you-know-who's trick to 4 and only 4 exception types >>> - MathArithmeticException >>> - MathIllegalArgumentException >>> - MathIllegalStateException >>> - MathUnsupportedOperationException >>> >>> Is that correct? >>> Sébastien >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org