On Aug 21, 2012, at 7:15 AM, Gilles Sadowski <gil...@harfang.homelinux.org> 
wrote:

> Hi.
> 
>> [...]
>> 
>> Added: 
>> commons/proper/math/trunk/src/main/java/org/apache/commons/math3/random/RandomDataGenerator.java
>> URL: 
>> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/random/RandomDataGenerator.java?rev=1375192&view=auto
>> ==============================================================================
>> --- 
>> commons/proper/math/trunk/src/main/java/org/apache/commons/math3/random/RandomDataGenerator.java
>>  (added)
>> +++ 
>> commons/proper/math/trunk/src/main/java/org/apache/commons/math3/random/RandomDataGenerator.java
>>  Mon Aug 20 19:53:57 2012
>> [...]
>> + *
>> + * @version $Id$
>> + */
>> +public class RandomDataGenerator implements RandomData, Serializable {
>> +
>> +    /** Serializable version identifier */
>> +    private static final long serialVersionUID = -626730818244969716L;
>> +
>> +    /** underlying random number generator */
>> +    private RandomGenerator rand = null;
>> +
>> +    /** underlying secure random number generator */
>> +    private SecureRandom secRand = null;
> 
> Should this class be "Serializable"?

I think so, yes.  It maintains state and all members are serializable.  (Need 
to check to make sure generators really are serializable).  Making it not 
serializable breaks EmpiricalDistribution.  EmpiricalDistribution instances and 
others that include instances of this class as members can be remoted.  I see 
that I forgot to generate serial version Id.  I will fix that if we agree to 
leave it serializable.

Phil
> 
> 
> Gilles
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to