On 20 July 2012 21:53, Dennis Lundberg <denn...@apache.org> wrote: > Hi sebb > > Some of these might have been put in there to avoid warnings from tools > like Checkstyle.
If CheckStyle insists on adding redundant semi-colons then it's badly configured or broken. > Should look at whether the warning count has increased > after this change. If so there are special annotations that can be used > to suppress these warnings explicitly. Should not be necessary to use annotations for redundant semicolons .. > On 2012-07-18 16:14, s...@apache.org wrote: >> Author: sebb >> Date: Wed Jul 18 14:14:29 2012 >> New Revision: 1362959 >> >> URL: http://svn.apache.org/viewvc?rev=1362959&view=rev >> Log: >> Redundant semi-colons >> >> Modified: >> >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java >> >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java >> >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/SimpleLog.java >> >> commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/NullTCCLTestCase.java >> >> Modified: >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java?rev=1362959&r1=1362958&r2=1362959&view=diff >> ============================================================================== >> --- >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java >> (original) >> +++ >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java >> Wed Jul 18 14:14:29 2012 >> @@ -511,7 +511,7 @@ public abstract class LogFactory { >> + ": [" + trim(e.getMessage()) >> + "]. Trying alternative implementations..."); >> } >> - ; // ignore >> + // ignore >> } catch(RuntimeException e) { >> // This is not consistent with the behaviour when a bad >> LogFactory class is >> // specified in a services file. >> @@ -588,7 +588,7 @@ public abstract class LogFactory { >> + ": [" + trim(ex.getMessage()) >> + "]. Trying alternative implementations..."); >> } >> - ; // ignore >> + // ignore >> } >> } >> >> @@ -922,7 +922,7 @@ public abstract class LogFactory { >> * we can make a distinction. >> */ >> if (e.getTargetException() instanceof SecurityException) { >> - ; // ignore >> + // ignore >> } else { >> // Capture 'e.getTargetException()' exception for >> details >> // alternate: log 'e.getTargetException()', and pass >> back 'e'. >> >> Modified: >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java?rev=1362959&r1=1362958&r2=1362959&view=diff >> ============================================================================== >> --- >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java >> (original) >> +++ >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java >> Wed Jul 18 14:14:29 2012 >> @@ -115,7 +115,7 @@ public class LogSource { >> setLogImplementation >> ("org.apache.commons.logging.impl.NoOpLog"); >> } catch (Throwable u) { >> - ; >> + // ignored >> } >> } >> } else { >> @@ -135,7 +135,7 @@ public class LogSource { >> setLogImplementation >> ("org.apache.commons.logging.impl.NoOpLog"); >> } catch (Throwable u) { >> - ; >> + // ignored >> } >> } >> } >> >> Modified: >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/SimpleLog.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/SimpleLog.java?rev=1362959&r1=1362958&r2=1362959&view=diff >> ============================================================================== >> --- >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/SimpleLog.java >> (original) >> +++ >> commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/SimpleLog.java >> Wed Jul 18 14:14:29 2012 >> @@ -140,7 +140,7 @@ public class SimpleLog implements Log, S >> try { >> prop = System.getProperty(name); >> } catch (SecurityException e) { >> - ; // Ignore >> + // Ignore >> } >> return (prop == null) ? simpleLogProps.getProperty(name) : prop; >> } >> @@ -661,7 +661,7 @@ public class SimpleLog implements Log, S >> classLoader = >> (ClassLoader)method.invoke(Thread.currentThread(), >> (Class[]) null); >> } catch (IllegalAccessException e) { >> - ; // ignore >> + // ignore >> } catch (InvocationTargetException e) { >> /** >> * InvocationTargetException is thrown by 'invoke' when >> @@ -680,7 +680,7 @@ public class SimpleLog implements Log, S >> * we can make a distinction. >> */ >> if (e.getTargetException() instanceof >> SecurityException) { >> - ; // ignore >> + // ignore >> } else { >> // Capture 'e.getTargetException()' exception for >> details >> // alternate: log 'e.getTargetException()', and >> pass back 'e'. >> @@ -690,7 +690,7 @@ public class SimpleLog implements Log, S >> } >> } catch (NoSuchMethodException e) { >> // Assume we are running on JDK 1.1 >> - ; // ignore >> + // ignore >> } >> } >> >> >> Modified: >> commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/NullTCCLTestCase.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/NullTCCLTestCase.java?rev=1362959&r1=1362958&r2=1362959&view=diff >> ============================================================================== >> --- >> commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/NullTCCLTestCase.java >> (original) >> +++ >> commons/proper/logging/trunk/src/test/org/apache/commons/logging/tccl/NullTCCLTestCase.java >> Wed Jul 18 14:14:29 2012 >> @@ -28,7 +28,7 @@ import junit.framework.TestCase; >> */ >> public class NullTCCLTestCase extends TestCase { >> >> - public static Test suite() throws Exception {; >> + public static Test suite() throws Exception { >> PathableTestSuite suite = new >> PathableTestSuite(NullTCCLTestCase.class, null); >> return suite; >> } >> >> > > > -- > Dennis Lundberg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
