On Tue, Jul 17, 2012 at 02:04:43AM +0300, ori ziv wrote: > * I updated the files (at > http://dl.dropbox.com/u/4481581/commons-math-suggestions.zip) > * I added the checkProbability method . Do you think that the > isProbability should not be public? > * I added an exception with a customized message. > * I didn't spot yet a place in CM that could use this is/check sample > space function. I thought it could be useful for any method the gets > probabilities which supposed to be a sample space. Don't you think > this case is common? > For example, in another class, InfoTheoryUtils, I've made a method > that calculates the mutual information and one of it arguments is > supposed to be a sample space. > * Any other remarks? > * Am I on the right track?
Thanks for your interest in contributing to Commons Math. However, you might want to start by focusing on a specific issue. E.g. this can be an improvement that is meant to simplify some of the code (like "checkProbability"), or the correction of bug. In most cases, you should provide a patch against the development version of Commons Math which you can retrieve from here: https://svn.apache.org/repos/asf/commons/proper/math/trunk This will enable the reviewers to check one thing at a time. [Feel free to ask more questions if this not clear.] Regards, Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
