On 29 March 2012 20:45, Benedikt Ritter <benerit...@googlemail.com> wrote:
> Hey,
>
> how about renaming CSVLexer.simpleTokenLexer() and
> CSVLexer.encapsulatedTokenLexer(), so that the method names express
> what the methods do?
> For example simpleTokenLexer() could be renamed to parseSimpleToken or
> parseSimpleTokenContent.
> Likewise encapsulatedTokenLexer() could be renamed to
> parseEncapsulatedToken or parseEncapsulatedTokenContent.

They are private methods so the name is arbitrary.
I also think the current names are OK.

I'm not sure I agree that the methods are parsers.
They are closer to lexers.

> Benedikt
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to