On 28 March 2012 17:50, Thomas Neidhart <thomas.neidh...@gmail.com> wrote: > On 03/28/2012 06:47 PM, sebb wrote: >> On 28 March 2012 17:14, Gary Gregory <garydgreg...@gmail.com> wrote: >>> Hi All: >>> >>> If there is anything you're itching to for for codec 1.7, now is the time. >> >> Any comments on CODEC-96 ? >> Base64 encode() method is no longer thread-safe, breaking clients >> using it as a shared BinaryEncoder >> >> The patch restores thread-safety, but Clirr reports binary compat issues. >> I think these are unlikely to be an actual problem, but this should be >> reviewed. > > I have reviewed your patch, see my comments attached to the issue.
Thanks, v. useful. I've updated the patch. > I did not look into the clirr issues yet. > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
