On 22 March 2012 19:03, Gary Gregory <garydgreg...@gmail.com> wrote: > On Thu, Mar 22, 2012 at 1:24 PM, sebb <seb...@gmail.com> wrote: > >> On 22 March 2012 17:21, sebb <seb...@gmail.com> wrote: >> > Presumably you have seen IO-311 ? >> > >> > -1 to proceeding with release until this is investigated, and resolved >> > as appropriate. >> >> I don't mean cancel the release vote - at least not just yet - but the >> issue needs to be evaluated before proceeding further with the vote >> process. >> > > While we are looking at this. The new methods in IOUtils.readFully feel > misnamed IMO. The makes makes it sounds like every thing will be read and > then used to stuff the buffer. Instead the methods "reads or fails (if the > required length is not met.)" > > How about: > > - readExactly > - readOrFail (because that's what it does) > - readChecked (because a checked exception can be thrown) > ?
The methods are analogous to the skipFully() ones, which I think are OK as names. Given that the buffer is provided by the user, it's not possible to read beyond it, so there cannot be a readFully method with the same signature that reads to EOF. I don't have a problem with the name. > Gary > >> >> > On 21 March 2012 22:23, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> On Wed, Mar 21, 2012 at 6:05 PM, Thomas Neidhart >> >> <thomas.neidh...@gmail.com>wrote: >> >> >> >>> On 03/18/2012 08:03 PM, Gary Gregory wrote: >> >>> > Hello All: >> >>> > >> >>> > This is a VOTE to release Commons IO 2.2-RC3 >> >>> > >> >>> > The changes from RC2 are: >> >>> > - Remove macro from release notes >> >>> > - Add binary compatibility to release notes >> >>> > - Information in src/site/xdoc/upgradeto2_2.xml was missing >> >>> > >> >>> > The changes from RC1 are: >> >>> > - Built from tag >> >>> > - Update release notes with version 2.2 >> >>> > - Update notice file with 2012 copyright >> >>> > - Update @version with $Id$ >> >>> > - Update site to link to only Javadoc 2.2 and 1.x. >> >>> > >> >>> > This VOTE is open for at least 72 hours until March 21 2012 at 15:15 >> EST. >> >>> > >> >>> > The files: >> >>> > >> >>> > >> https://repository.apache.org/content/repositories/orgapachecommons-087/ >> >>> > >> >>> > The tag: >> >>> > >> >>> > https://svn.apache.org/repos/asf/commons/proper/io/tags/2.2-RC3 >> >>> > >> >>> > The site: >> >>> > >> >>> > https://people.apache.org/builds/commons/commons-io/2.2/RC3/ >> >>> >> >>> The javadoc contents for release 2.2 and 1.4 (in the Commons IO menu) >> >>> are missing. >> >>> >> >> >> >> Check. That will be handled when the site is published. >> >> >> >> Gary >> >> >> >> >> >>> >> >>> Apart from that: +1 >> >>> >> >>> Thomas >> >>> >> >>> --------------------------------------------------------------------- >> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> >>> For additional commands, e-mail: dev-h...@commons.apache.org >> >>> >> >>> >> >> >> >> >> >> -- >> >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >> >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >> >> Blog: http://garygregory.wordpress.com >> >> Home: http://garygregory.com/ >> >> Tweet! http://twitter.com/GaryGregory >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
