On Sun, Mar 18, 2012 at 5:12 PM, Thomas Neidhart <thomas.neidh...@gmail.com>wrote:
> On 03/18/2012 05:49 PM, Gary Gregory wrote: > > >> One additional thing: the fix for the QuotedPrintableCodec changed > >> (slightly) the behavior of the encoding/decoding. As I have seen in some > >> other classes, similar changes have been documented in the javadoc of > >> the affected methods as well (e.g. Base64#encodeBase64String). > >> > >> Do you think we should do it also in this case? > > > > How would state this in the javadocs. I am now worried about > > compatibility. Would it better to back out the change? > > After some thinking, I believe this change has to wait till 2.0, as it > would break compatibility. > > A string encoded with the changed QuotedPrintableCodec can not be read > by an application using codec-1.6 or earlier (if it contains a soft line > break). > > Also the decode behaves slightly different (more correct), as it will > ignore any non-encoded CR/LF character. In prior version these special > chars were treated like normal chars. > Ok, can you: (1) back out the QuotedPrintableCodec changes and (2) complete Codec-130? Thank you, Gary > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory