On Sun, Mar 04, 2012 at 08:06:08PM -0500, Gary Gregory wrote: > Sorry for the nitpicking, but the RAT report still shows missing Apache > headers: > > - src/test/R/KolmogorovSmirnovDistributionTestCases.R > - css files > > I've taken the liberty to fix those in SVN.
Thanks. > > There are low-hanging fruits that should be fixed IMO as reported by PMD: > > - No need to import a type that lives in the same package (just ugly) Agreed, but hardly a bug or a blocking issue. Don't hesitate to help fixing those whenever you can. In Commons Math, we seem to be "CheckStyle"-centric... From now on I'll pay attention to PMD too. > - Avoid unnecessary return statements (really ugly, some of these are > "return;" as the last statement in methods) Thanks for noticing. I certainly agree that this code should not have made into Commons Math... And IMHO, it is there because of the reluctance of some people to have an explicit set of coding style rules. [This suggestion has been put forward several times, by at least two persons, but was met with skepticism as to its usefulness.] > [...] Best regards, Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
