AccessibleObjectRegistry.AccessibleObjectDescriptor is used internally only, users don't even know that it exist and it is used only as a key for the AccessibleObject index. Does it make sense checking other types, nulls, assignability from super/subclasses, ... etc?
http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Mar 1, 2012 at 3:09 PM, Benedikt Ritter <b...@systemoutprintln.de> wrote: > Hi, > > I just ran the eclipse FindBugs plugin with default configuration on > BeanUtils2 and it pointed me to equals() in > AccessibleObjectRegistry.AccessibleObjectDescriptor, reporting that the cast > in line 535 > > AccessibleObjectDescriptor other = (AccessibleObjectDescriptor) obj; > > is not checked for null. > Now I'd like to implement equals() like it is shown in Effective Java. Are > there any arguments against changing the implementation that way? > > Regards, > Benedikt > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
