On Mon, Feb 27, 2012 at 11:58 AM, sebb <seb...@gmail.com> wrote: > On 27 February 2012 15:49, sebb <seb...@gmail.com> wrote: > > On 27 February 2012 14:48, Gary Gregory <garydgreg...@gmail.com> wrote: > >> On Sat, Feb 25, 2012 at 8:14 PM, Gary Gregory <garydgreg...@gmail.com > >wrote: > >> > >>> On Feb 25, 2012, at 19:18, sebb <seb...@gmail.com> wrote: > >>> > >>> > On 25 February 2012 14:46, Gary Gregory <garydgreg...@gmail.com> > wrote: > >>> >> On Sat, Feb 25, 2012 at 9:23 AM, sebb <seb...@gmail.com> wrote: > >>> >> > >>> >>> On 25 February 2012 14:11, Gary Gregory <garydgreg...@gmail.com> > >>> wrote: > >>> >>>> On Fri, Feb 24, 2012 at 8:23 PM, sebb <seb...@gmail.com> wrote: > >>> >>>> > >>> >>>>> On 25 February 2012 00:47, <ggreg...@apache.org> wrote: > >>> >>>>>> Author: ggregory > >>> >>>>>> Date: Sat Feb 25 00:47:00 2012 > >>> >>>>>> New Revision: 1293496 > >>> >>>>>> > >>> >>>>>> URL: http://svn.apache.org/viewvc?rev=1293496&view=rev > >>> >>>>>> Log: > >>> >>>>>> Update plugins. > >>> >>>>>> > >>> >>>>>> Modified: > >>> >>>>>> commons/proper/commons-parent/trunk/pom.xml > >>> >>>>>> > >>> >>>>>> Modified: commons/proper/commons-parent/trunk/pom.xml > >>> >>>>>> URL: > >>> >>>>> > >>> >>> > >>> > http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1293496&r1=1293495&r2=1293496&view=diff > >>> >>>>>> > >>> >>>>> > >>> >>> > >>> > ============================================================================== > >>> >>>>>> --- commons/proper/commons-parent/trunk/pom.xml (original) > >>> >>>>>> +++ commons/proper/commons-parent/trunk/pom.xml Sat Feb 25 > 00:47:00 > >>> >>> 2012 > >>> >>>>>> @@ -193,12 +193,12 @@ Version 23: > >>> >>>>>> <plugin> > >>> >>>>>> <groupId>org.apache.maven.plugins</groupId> > >>> >>>>>> <artifactId>maven-antrun-plugin</artifactId> > >>> >>>>>> - <version>1.6</version> > >>> >>>>>> + <version>1.7</version> > >>> >>>>>> </plugin> > >>> >>>>>> <plugin> > >>> >>>>>> <groupId>org.apache.maven.plugins</groupId> > >>> >>>>>> <artifactId>maven-assembly-plugin</artifactId> > >>> >>>>>> - <version>2.2.1</version> > >>> >>>>>> + <version>2.3</version> > >>> >>>>>> </plugin> > >>> >>>>>> <plugin> > >>> >>>>>> <groupId>org.apache.maven.plugins</groupId> > >>> >>>>>> @@ -262,7 +262,7 @@ Version 23: > >>> >>>>>> <plugin> > >>> >>>>>> <groupId>org.apache.maven.plugins</groupId> > >>> >>>>>> <artifactId>maven-release-plugin</artifactId> > >>> >>>>>> - <version>2.2.1</version> > >>> >>>>>> + <version>2.2.2</version> > >>> >>>>>> </plugin> > >>> >>>>>> <plugin> > >>> >>>>>> <!-- TODO see above - find better way to add N&L > files to > >>> >>> jars > >>> >>>>> and test jars --> > >>> >>>>>> @@ -318,7 +318,7 @@ Version 23: > >>> >>>>>> <groupId>org.apache.felix</groupId> > >>> >>>>>> <artifactId>maven-bundle-plugin</artifactId> > >>> >>>>>> <!-- N.B. 2.3.5 does not work on Java 5; see profile > >>> >>>>> java-1.5-detected for the workround --> > >>> >>>>>> - <version>2.3.5</version> > >>> >>>>>> + <version>2.3.6</version> > >>> >>>>> > >>> >>>>> Does 2.3.6 work with java 1.5? > >>> >>>>> > >>> >>>>> If so, maybe the work-round can be commented out or removed? > >>> >>>>> > >>> >>>> > >>> >>>> Sure, that makes sense. > >>> >>>> > >>> >>>> Seems to be ok for me when I build [codec] with: > >>> >>>> > >>> >>>> Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > >>> >>>> Maven home: C:\Java\apache-maven-3.0.4\bin\.. > >>> >>>> Java version: 1.5.0_22, vendor: Sun Microsystems Inc. > >>> >>>> Java home: C:\Program Files\Java\jdk1.5.0_22\jre > >>> >>>> Default locale: en_US, platform encoding: Cp1252 > >>> >>>> OS name: "windows 7", version: "6.1", arch: "amd64", family: > "windows" > >>> >>>> > >>> >>>> I see: > >>> >>>> > >>> >>>> [INFO] --- maven-bundle-plugin:2.3.6:manifest (bundle-manifest) @ > >>> >>>> commons-codec --- > >>> >>>> > >>> >>>> No stack traces or errors. > >>> >>> > >>> >>> Need to check M2.2.1 as well. > >>> >>> > >>> >> > >>> >> Build successful with: > >>> >> > >>> >> Apache Maven 2.2.1 (r801777; 2009-08-06 15:16:01-0400) > >>> >> Java version: 1.5.0_22 > >>> >> Java home: C:\Program Files\Java\jdk1.5.0_22\jre > >>> >> Default locale: en_US, platform encoding: Cp1252 > >>> >> OS name: "windows 7" version: "6.1" arch: "amd64" Family: "windows" > >>> > > >>> > Did you disable the java-1.5-detected profile? > >>> > > >>> > That is automatically enabled when running under Java 1.5, and > selects > >>> > earlier versions in order to fix this. > >>> > >> > >> I deleted the java-1.5-detected profile in the parent POM and installed > it > >> locally (mvn install). > >> > >> Then I made [codec] use this 24-SNAPSHOT parent POM with M3 and M2 (mvn > >> install) and builds were successful and create jars with OSGi-looking > >> manifests. > >> > >> So I suppose this means the java-1.5-detected profile is not needed > anymore > >> but as I am not a Maven expert on this specific issue I'll not delete it > >> ATM. > > > > OK, I may have time to try it later this week; > > What I intend to do is: > > - disable the current override for java 1.5 > > - check that the bind command fails when building (IIRC, the problem > > was a bind plugin dependency that was built with Java 1.6) > > - update to the latest bind plugin > > - check that the bind command succeeds > > > > If anyone else can try that too, so much the better. > > If I disable the 1.5 workround, for example by using > > mvn bundle:manifest -P-java-1.5-detected > > [i.e. no need to edit the pom to test this] > > then Maven 2.2.1/Java 1.5/ Bundle 2.3.5 fails for me with > > [ERROR] FATAL ERROR > [INFO] > ------------------------------------------------------------------------ > [INFO] java.lang.String.getBytes(Ljava/nio/charset/Charset;)[B > [INFO] > ------------------------------------------------------------------------ > [INFO] Trace > java.lang.NoSuchMethodError: > java.lang.String.getBytes(Ljava/nio/charset/Charset;)[B > at aQute.lib.osgi.Jar.<clinit>(Jar.java:290) > > However, updating the bundle plugin to 2.3.6 fixes the issue, so it > does look like the hack can be removed - yay! >
Nice Mavening Sebb! :) Gary > > >> Gary > >> > >> > >>> How do I disable it from the cli? > >>> > >>> Gary > >>> > > >>> > Testing with Java 1.5 and bundle 2.3.6 does not prove anything unless > >>> > the profile override is disabled. > >>> > > >>> > --------------------------------------------------------------------- > >>> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> > For additional commands, e-mail: dev-h...@commons.apache.org > >>> > > >>> > >> > >> > >> > >> -- > >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > >> Blog: http://garygregory.wordpress.com > >> Home: http://garygregory.com/ > >> Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
