On 6 December 2011 15:38, Siegfried Goeschl <sgoes...@gmx.at> wrote: > Hi Gary, > > ad RAT - I added a license header for "mime.types" but doing this for the > mail messages is not possible AFAIK since there is no such thing as a > comment for mail messages > > ad src zip - need to check since I did a last minute upgrade to the latest > commons-parent.pom > > ad Clirr errors - this reported errors are stemming from two changes > > 1) I introduced an "EmailConstants.java" to collect all the constants and > Email implements EmailConstants
Not sure about that one, I'll check. It may be a false positive as far as binary compatibility is concerned, but it certainly breaks source compatibility and should be clearly documented in the release notes. > 2) the setter methods of Email return now consistently "this" instead of > void This definitely breaks binary compatibilty; we had a similar issue in Commons IO. The JVM includes the return type in the method signature when resolving references; changing the return type will cause "method not found" or similar. > IMHO both changes do not break binary compatibility for the minor release > Cheers, > > Siegfried Goeschl > > > > On 05.12.11 23:11, Gary Gregory wrote: >> >> Hi Siegfried: >> >> Thank you for preparing the RC. >> >> This /sounds/ worrisome from RAT: >> >> Unapproved licenses: >> >> >> src/resources/META-INF/mime.types >> >> src/test/eml/attachment-only.eml >> >> src/test/eml/html-attachment.eml >> >> src/test/eml/multipart-report.eml >> >> src/test/eml/simple-reply.eml >> >> src/test/eml/simple.eml >> >> >> Where is the 'src' zip I can build from? >> >> Looks like there are three easy to fix checkstyle errors (not the >> missing Javadocs.) >> >> -1: Can you justify the 51 Clirr errors in a minor release? >> >> Our current guideline is that such a change means a major version and >> new package. I do not care which way we go but we should be mindful of >> binary compatibility for minor release. >> >> Thank you, >> Gary >> >> On Mon, Dec 5, 2011 at 4:31 PM, Siegfried Goeschl <sgoes...@gmx.at >> <mailto:sgoes...@gmx.at>> wrote: >> >> Hi folks, >> >> I would like to call a vote to release commons-email-1.3 which >> contains the following bug fixes and improvements found here >> >> >> http://people.apache.org/__builds/commons/email/1.3/RC2/__site/changes-report.html >> >> <http://people.apache.org/builds/commons/email/1.3/RC2/site/changes-report.html> >> >> Tag: >> >> >> https://svn.apache.org/repos/__asf/commons/proper/email/tags/__EMAIL_1_3_RC2 >> >> <https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_RC2> >> >> Site: >> >> >> http://people.apache.org/__builds/commons/email/1.3/RC2/__site/index.html >> <http://people.apache.org/builds/commons/email/1.3/RC2/site/index.html> >> >> Binaries: >> >> >> http://people.apache.org/__builds/commons/email/1.3/RC2/__staged/org/apache/commons/__commons-email/1.3/ >> >> >> <http://people.apache.org/builds/commons/email/1.3/RC2/staged/org/apache/commons/commons-email/1.3/> >> >> [ ] +1 release it >> [ ] +0 go ahead I don't care >> [ ] -1 no, do not release it because >> >> Thanks in advance >> >> Siegfried Goeschl >> >> >> ------------------------------__------------------------------__--------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.__apache.org >> <mailto:dev-unsubscr...@commons.apache.org> >> >> For additional commands, e-mail: dev-h...@commons.apache.org >> <mailto:dev-h...@commons.apache.org> >> >> >> >> >> -- >> E-Mail: garydgreg...@gmail.com <mailto:garydgreg...@gmail.com> | >> ggreg...@apache.org <mailto:ggreg...@apache.org> >> >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> >> >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
