On 28 November 2011 14:30, sebb <seb...@gmail.com> wrote: > On 28 November 2011 14:19, henrib <hen...@apache.org> wrote: >> Thanks for tidying up my mess. >> >> About org.apache.commons.jexl2.UnifiedJEXL$Expression, its subclasses are >> private because only that base class is supposed to be usable by end-users; >> one declares 'UnifiedJEXL.Expression expr' and the engine manages the rest. > > That's a pity. > >> org.apache.commons.jexl2.internal is definitely internal (sic :-)). > > OK, I'll exclude it.
Done. >> org.apache.commons.jexl2.introspection is intended to be used as a base to >> customization so should be considered public (albeit most likely never used >> by anyone); Uberspect.getConstructor was not carrying the proper signature >> in 2.0.x. Would it be possible to add a new method to the Impl that has the correct sig and deprecate the old one? e.g. getConstructorMethod ? If the interface is unlikely to be directly used externally, then it might be OK to allow that as an API break. >> >> The amount of work to try to make the release binary compatible seems >> unfortunately much greater than switching to a new package name... > > Are you sure? > > I thought so originally with NET which needed quite a major refactor, > but found that I could add new methods and deprecate old ones. > > I'm happy to do some of the work, but as indicated I'm not entirely > sure what is intended to be external. > >> Thanks again for your help, >> Henrib >> >> >> -- >> View this message in context: >> http://apache-commons.680414.n4.nabble.com/VOTE-Release-JEXL-2-1-based-on-RC1-tp4113403p4115331.html >> Sent from the Commons - Dev mailing list archive at Nabble.com. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
