Hi all, 

I was having a look at the items pointed by Emmanuel Bourg during the call for 
votes of release 1.0. 


One of the items was related to the fact that all Functors in 
org.apache.commons.functor.core implement Serializable, with exception of Limit 
and Offset. I was going home but before decided to create an issue with a patch 
for this item, however almost left without running the tests. That was when I 
noticed that I've broke the build (sorry about the noise with the mails from 
JIRA updates).

These classes cannot be marked as Serializable due to the fact that they do not 
override equals (nor hashcode). 


In the bottom of the file, there is the following comment: "//default == 
equals/hashCode due to statefulness"

Could somebody explain why Limit and Offset does not override equals? Please.

Wouldn't it be valid to say that a Limit(max=3, current=0) is equals to another 
Limit with same max and current values? 


Thank you in advance and sorry about the noise again.

Cheers,
Bruno P. Kinoshita

Reply via email to