On 14 September 2011 20:34, <simonetrip...@apache.org> wrote: > Author: simonetripodi > Date: Wed Sep 14 19:34:37 2011 > New Revision: 1170805 > > URL: http://svn.apache.org/viewvc?rev=1170805&view=rev > Log: > fixed checkstyle violation: Method 'hashCode' is not designed for extension - > needs to be abstract, final or empty
Is the class intended for extension? If so, and you add fields, you won't be able to override hashCode to take account of them. If not, just make the class final. Are you sure that the Checkstyle complaint is valid here? > Modified: > > commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java > > Modified: > commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java > URL: > http://svn.apache.org/viewvc/commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java?rev=1170805&r1=1170804&r2=1170805&view=diff > ============================================================================== > --- > commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java > (original) > +++ > commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java > Wed Sep 14 19:34:37 2011 > @@ -107,7 +107,7 @@ public class TransformedBinaryProcedure< > * {@inheritDoc} > */ > @Override > - public int hashCode() { > + public final int hashCode() { > int result = "TransformedBinaryProcedure".hashCode(); > result <<= 2; > result |= helper.procedure.hashCode(); > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
