On 7 September 2011 13:26, Gary Gregory <garydgreg...@gmail.com> wrote:
> Should LockableFileWriter.close() be changed from:
>
>    public void close() throws IOException {
>        try {
>            out.close();
>        } finally {
>            lockFile.delete();
>        }
>
> to:
>
>    public boolean close() throws IOException {
>        try {
>            out.close();
>        } finally {
>            return lockFile.delete();
>        }
>
> ?

That will break binary compatibility - the return type is part of the
method signature.

So no, unless the method is new.

There's an IO JIRA about this somewhere.

> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> JUnit in Action, 2nd Ed: http://s.apache.org/rl
> Spring Batch in Action: http://s.apache.org/HOq
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to