On 2011-08-09, Phil Steitz wrote: > On 8/8/11 11:29 PM, Stefan Bodewig wrote: >> On 2011-08-08, Phil Steitz wrote:
>>> As a test of whether or not it will work, I would recommend writing >>> the javadoc and test cases first (which of course we all do any way ;) >> Javadocs are there now with svn rev 1155223, in particular >> <http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.java?r1=1154667&r2=1155223> >> It would be good if anybody who didn't have to dive as deeply inside the >> ZIP format as myself could read it to ensure it makes some sense. >> Proof-reading by a native speaker certainly won't hurt either. > Looks clear enough, Thanks. > but it would be good to specify what happens (i.e. what exception or > failure mode happens) when the setting is not valid. Looks like only > asNeeded needs a comment for this. Yes, I've added some @throws clauses in later commits. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
