On Thu, Jul 21, 2011 at 9:08 AM, Christian Grobmeier <[email protected]> wrote: > On Thu, Jul 21, 2011 at 9:50 AM, Henri Yandell <[email protected]> wrote: >> I think the argument is the other way. You should be explaining why >> you wouldn't simply just move to Java 5. > > +1 - Java 1.4 must die now. > >> +1 to JDK 1.5 minimum. > > +1 > > If we lift up to 1.5 as a minimum what about lifting to compress 2.0? > Then we can speak about generics and enums too because we don't need > to be so strict on BC :-)
Moving to Java 5 and using generics doesn't necessarily mean a break in backwards compatibility. Commons IO 2.0 did this and was backwardly compatible. I would suggest doing the compatible changes first and make a list(JIRA) of incompatible changes. If its small then it may be more desirable to deprecate & add new method names. Niall > Cheers > Christian > >> >> Hen >> >> On Wed, Jul 20, 2011 at 9:04 PM, Stefan Bodewig <[email protected]> wrote: >>> Hi, >>> >>> no, this is not about generics or enums or ... >>> >>> This time it is methods added in the classlib, in particular >>> java.util.zip.Inflater#getBytesRead and friends which return longs >>> rather than ints that are returned by getTotalIn. >>> >>> Since ZIP entry size is an unsigned four byte int even without Zip64 >>> support it simply doesn't fit into an int and some bugs cannot properly >>> be fixed by using the Java4 method. (COMPRESS-129 is one). >>> >>> Things will become worse with Zip64 as we'd need unsigned longs but I'm >>> willing to accept that as theoretical cases. >>> >>> The alternative would be to use some reflection magic inside the ZIP >>> package (which I'm willing to do). >>> >>> Stefan >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > > -- > http://www.grobmeier.de > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
