Hi Sven, thanks, that's the kind of feedbacks! I like your suggestion about having the #stop() methods, would you like to provide a patch? Every contribution is more than welcome!
You are right, let's properly rename classes and make the Visitor required. Tell me if you want to provide a patch also for this, otherwise I can do it by myself. My work concerns also involving the community, so I would like you encouraged on submitting patches!! Many thanks in advance, have a nice weekend! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Sat, Jun 18, 2011 at 7:28 PM, Sven Meier <s...@meiers.net> wrote: > Hi, > > nice work so far. > > IMHO the API could be improved a little bit: > - A GraphVisitHandler is a "Visitor", why not name it that way? > - If visitor's methods would be given a "Visit" argument, it would allow > them to control the traversal, e.g.: > #stop() to stop traversal > #stop(R result) to stop traversal with a return value > > BTW the current traversal methods in Visit have to check for a null visitor > over and over again, so why not make the argument required? > > My 2 cents > > Sven > > On 06/17/2011 04:47 PM, Simone Tripodi wrote: >> >> Hi Arshad, >> if you want some initial point to attack, you can continue >> implementing memory-based data-structures, take a look at base and the >> org.apache.commons.graph.model packages. >> And feel free to ask any question! >> Looking forward to hear from you soon, have a nice day! >> Simo >> >> http://people.apache.org/~simonetripodi/ >> http://www.99soft.org/ >> >> >> >> On Fri, Jun 17, 2011 at 3:16 PM, Arshad Ansari<arshadansar...@gmail.com> >> wrote: >>> >>> Hi Simone, >>> >>> Many thanks for the help. I may as well get started :) >>> >>> Thanks and regards, >>> Arshad >>> >>> On 17 June 2011 18:19, Simone Tripodi<simonetrip...@apache.org> wrote: >>> >>>> Hi Arshad, >>>> you can fill issues and attach patches on >>>> https://issues.apache.org/jira/browse/SANDBOX just prefixing the >>>> issues with [graph]. >>>> Have a good job! >>>> Simo >>>> >>>> http://people.apache.org/~simonetripodi/ >>>> http://www.99soft.org/ >>>> >>>> >>>> >>>> On Fri, Jun 17, 2011 at 1:43 PM, Simone Tripodi >>>> <simonetrip...@apache.org> wrote: >>>>> >>>>> Hi Arshad, >>>>> site links are now fixed and (empty) graph site is online, now going >>>>> to ask about JIRA. >>>>> Stay tuned! :) >>>>> Simo >>>>> >>>>> http://people.apache.org/~simonetripodi/ >>>>> http://www.99soft.org/ >>>>> >>>>> >>>>> >>>>> On Fri, Jun 17, 2011 at 12:58 PM, Arshad Ansari >>>>> <arshadansar...@gmail.com> wrote: >>>>>> >>>>>> Hi Simone, >>>>>> >>>>>> Thanks for the reply and for clarifications. I really appreciate it. >>>>>> >>>>>> Thanks and regards, >>>>>> Arshad >>>>>> >>>>>> On 17 June 2011 12:59, Simone Tripodi<simonetrip...@apache.org> >>>>>> wrote: >>>>>> >>>>>>> Hi Arshad, >>>>>>> "graph not listed as a project under sandbox" you are maybe referring >>>>>>> to sites list, because if you browse the SVN[1] you can see graph[2] >>>>>>> there. >>>>>>> I'll upload the graph site ASAP since I need to maintain the sandbox >>>> >>>> sites. >>>>>>> >>>>>>> JIRA not available yet for Graph, I'll open a new separated thread >>>>>>> about it. No way to create an alternative workflow than the ASF one, >>>>>>> no attachements to email please. >>>>>>> Thanks for your interest, looking forward to see you active on >>>>>>> graph!!! >>>>>>> Simo >>>>>>> >>>>>>> [1] http://svn.apache.org/viewvc/commons/sandbox/ >>>>>>> [2] http://svn.apache.org/viewvc/commons/sandbox/graph/trunk >>>>>>> >>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>> http://www.99soft.org/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Jun 17, 2011 at 6:42 AM, Arshad Ansari< >>>> >>>> arshadansar...@gmail.com> >>>>>>> >>>>>>> wrote: >>>>>>>> >>>>>>>> Hello Simone, >>>>>>>> Thanks for the update, we have been waiting. Although, I had this >>>>>>> >>>>>>> question, >>>>>>>> >>>>>>>> I don't see the graph being listed as a project under sandbox, now >>>> >>>> that >>>>>>> >>>>>>> it >>>>>>>> >>>>>>>> is moved there. My questions was related to how to submit patches or >>>>>>> >>>>>>> bugs. >>>>>>>> >>>>>>>> as I don't see the project in Jira as well. Is it ok, if I submit it >>>> >>>> here >>>>>>> >>>>>>> as >>>>>>>> >>>>>>>> attachments? >>>>>>>> Thanks in advance for the help. >>>>>>>> Arshad >>>>>>>> >>>>>>>> On 17 June 2011 03:17, Simone Tripodi<simonetrip...@apache.org> >>>> >>>> wrote: >>>>>>>>> >>>>>>>>> a >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>> >>>>>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
