On Wed, May 18, 2011 at 8:17 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
> On Wed, May 18, 2011 at 9:37 AM, sebb <seb...@gmail.com> wrote:
>
>> I think the method (new to 3.0)
>>
>> FormatCache.getDateTimeInstance(Integer dateStyle, Integer timeStyle,
>> TimeZone timeZone, Locale locale)
>>
>> should be changed to use ints, as all the existing callers use ints.
>>
>> Furthermore, the parameters have to be unboxed in order to pass them
>> to DateFormat, so the boxing/unboxing is unnecessary and wasteful.
>>
>> OK?
>>
>
> +1
>
>
>>
>> I've not raised a JIRA for this because it is new code that has not
>> been released - but I'm happy to do so if others think a JIRA entry is
>> necessary here.
>>
>
> No JIRA needed IMO.

+1. Go for it.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to