indeed, thanks for reviewing! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/
On Sat, May 14, 2011 at 2:29 AM, sebb <seb...@gmail.com> wrote: > On 14 May 2011 00:55, <simonetrip...@apache.org> wrote: >> Author: simonetripodi >> Date: Fri May 13 23:55:05 2011 >> New Revision: 1102928 >> >> URL: http://svn.apache.org/viewvc?rev=1102928&view=rev >> Log: >> HashSet is more than enough to check reserved words >> >> Modified: >> >> incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java >> >> Modified: >> incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java >> URL: >> http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java?rev=1102928&r1=1102927&r2=1102928&view=diff >> ============================================================================== >> --- >> incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java >> (original) >> +++ >> incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java >> Fri May 13 23:55:05 2011 >> @@ -50,7 +50,7 @@ public class OgnlContext extends Object >> public static final TypeConverter DEFAULT_TYPE_CONVERTER = new >> DefaultTypeConverter(); >> public static final MemberAccess DEFAULT_MEMBER_ACCESS = new >> DefaultMemberAccess(false); >> >> - private static Map RESERVED_KEYS = new HashMap(11); >> + private static Set<String> RESERVED_KEYS = new HashSet<String>(11); > > Could be made final too. > >> private Object _root; >> private Object _currentObject; >> @@ -70,15 +70,15 @@ public class OgnlContext extends Object >> static { >> String s; >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
