On 4/30/11 3:02 PM, Simone Tripodi wrote: > Hi Phil, > thanks for reviewing, very appreciated! > > 0) is it fine fixing these warning for the current SNAPSHOT? Yes, that is what I meant by not a showstopper. I am +1 on releasing as is. > 1) indeed, they have been generated by the release-plugin. How do we > manage this situation? Do we update them manually before/after tagging > the release? I don't think there is anything that can be done about it. You definitely do not want to mess with the tag since then the release will not correspond to the tag. This also is not a showstopper.
Phil > Many thanks in advance, > Simo > > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > > > > On Sat, Apr 30, 2011 at 11:31 PM, Phil Steitz <phil.ste...@gmail.com> wrote: >> On 4/27/11 12:38 PM, Simone Tripodi wrote: >>> Hi all guys! >>> After the failed RC1, I'm here to propose a new Apache >>> Commons-DIscovery release, based on RC2, please cast your votes! >>> Many thanks in advance to everybody will take part to the vote process :) >>> All the best, >>> Simo >>> >>> Release notes: >>> >>> http://people.apache.org/builds/commons/discovery/0.5/RC2/RELEASE-NOTES.txt >>> >>> Tag: >>> >>> http://svn.apache.org/repos/asf/commons/proper/discovery/tags/DISCOVERY_0_5_RC2/ >>> >>> Site: >>> >>> http://people.apache.org/builds/commons/discovery/0.5/RC2/site/ >>> >>> Binaries: >>> >>> http://people.apache.org/builds/commons/discovery/0.5/RC2/staged/commons-discovery/commons-discovery/0.5/ >>> >>> [ ] +1 release it >>> [ ] +0 go ahead I don't care >>> [ ] -1 no, do not release it because >>> >>> http://people.apache.org/~simonetripodi/ >>> http://www.99soft.org/ >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> +1 >> >> Verified sigs and hashes and tested build with JDK 1.6.0_24 >> >> Small non-show-stopping nits: >> >> 0) lots of findbugs warnings - none look like real bugs to me, but >> they should be documented and excluded in findbugs config >> 1) release pom has wrong scm connection info (this is an artifact of >> using the release plugin AIUI) >> >> Phil >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org