On Apr 23, 2011, at 7:10, "Jörg Schaible" <joerg.schai...@gmx.de> wrote:
> Gary Gregory wrote:
>
>> Hi All:
>>
>> I find that the new 'valid' method names in Validate make for odd reading.
>>
>> I think a verb like 'validate*' or 'check*' would be better. Especially
>> when the Javadocs all start with 'Validates...'.
>>
>> I do see 'check' used in other internal APIs for this kind of behavior.
>> For example, Java Swing and Eclipse SWT use 'check*' methods to validate
>> state and throw exceptions.
>>
>> For example:
>>
>> public void doSomething(String str) {
>> Validate.validateIndex(str, 1);
>>
>> or:
>>
>> public void doSomething(String str) {
>> Validate.checkIndex(str, 1);
>>
>> The Validate class name is odd too because it is a verb. I would expect
>> Validator:
>>
>> public void doSomething(String str) {
>> Validator.validateIndex(str, 1);
>>
>> A validator validates (or checks) values.
>>
>> I think I like best the 'check*' methods, probably because I've seen them
>> in SWT and Swing for so long.
>>
>> Thoughts?
>
> Validator.checkXXX sounds reasonable.
I am moving today, so I might not get to this until later. If someone
can jump in that would be great.
Gary
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
