On 25 February 2011 03:14, Phil Steitz <phil.ste...@gmail.com> wrote:
> On 2/24/11 2:52 PM, Luc Maisonobe wrote:
>> Le 24/02/2011 19:56, sebb a écrit :
>>> On 24 February 2011 17:46, Luc Maisonobe <luc.maison...@free.fr> wrote:
>>>> Le 24/02/2011 18:31, sebb a écrit :
>>>>> On 24 February 2011 17:26, Luc Maisonobe <luc.maison...@free.fr> wrote:
>>>>>> Le 24/02/2011 18:17, sebb a écrit :
>>>>>>> No, the patch does not work.
>>>>>>>
>>>>>>> However, the following code does seem to work for me on both 1.5 and 1.6
>>>>>>>
>>>>>>> if (ra == 0) { // Fix up the sign so atan works correctly
>>>>>>> ra = copySign(0.0, y);
>>>>>>> }
>>>>>>>
>>>>>>> i.e. always copy the sign of y, not just when negative.
>>>>>> I don't see the difference with my patch
>>>>> Huh?
>>>>>
>>>>> Mine is:
>>>>>
>>>>> if (ra == 0) { // Fix up the sign so atan works correctly
>>>>> ra = copySign(0.0, y);
>>>>> }
>>>>>
>>>>> Yours is:
>>>>>
>>>>> if (ra == 0) && (y < 0)) { // Fix up the sign so atan works
>>>>> correctly
>>>>> ra = copySign(0.0, y);
>>>>> }
>>>> No. I copied a diff, so the '-' characters at the beginning of the lines
>>>> showed the deleted lines (i.e. the current code) and the '+'
>>>> characters show the added lines (i.e. the patch).
>>>>
>>>> So if people agree, I will cancel vote and start an RC4 with this patch
>>>> included.
>>>>
>>>> Does this sound reasonable ?
>>> OK to me, but you might want to ask the others by posting to DEV ...
>> Sorry, I didn't check the recipîents before sending the mail.
>>
>>>
>>> By the way, it might be better to deploy at least the Maven artifacts
>>> to Nexus staging, as this makes deploying the Maven stuff easier.
>>> [Have to remove the non-Maven stuff before release]
>> I'll try it. I have never made a release before and was simply using
>> Phil's scripts for [math]. I'm learning here.
>>
> What the script creates is an exact pre-image of what you can just
> copy to m2-ibiblio-rysnch (following the instructions in step 3 of
> http://commons.apache.org/releases/release.html). I would
> personally recommend staying away from Nexus unless you want to
> spend a lot of time tinkering with the build. It will also
> invalidate the vote unless you ditch the scripts, get nexus to
> deploy to the staging repo and point the vote at the staging repo.
I'm not sure it's possible to write to the m2-ibiblio-rysnch directory
once Nexus is in use; AFAIK the protections are changed.
Anyway it seems Luc has successfully uploaded to Nexus.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
