On 2/18/11 2:14 PM, sebb wrote: > I agree it's helpful to have at least the subject of the JIRA in the > log message, but IMO there should be nothing in the log message that > is not in the JIRA and/or code comments. > > The SVN log message should enable reviewers to understand the content > of the commit but should otherwise be disposable. SVN log messages are > not versioned, so can be permanently overwritten. Also we release > source code, and if SVN log messages are necessary to understand the > code, then the comments are insufficient. > I agree that svn log messages should not be necessary to understand the code; but they are a very important tool in understanding how the revision history works - i.e., what was changed when. The fact that they can be modified is a plus - it means we can go back and fix errors in the log messages or improve them. I am frequently thankful of developers who have written good and complete commit messages not for understanding how code works, but why it works the way it does. I personally have no problem at all with duplication between the content of these messages and comments and/or descriptions in JIRA.
Phil > S. > On 18 February 2011 17:22, henrib <hen...@apache.org> wrote: >> Sorry about that; will do. Got it reversed between what I write in Jira and >> in the svn log. >> Regards, >> Henrib >> -- >> View this message in context: >> http://apache-commons.680414.n4.nabble.com/Re-jexl-Short-description-in-commit-messages-was-svn-commit-r1072000-tp3312834p3313182.html >> Sent from the Commons - Dev mailing list archive at Nabble.com. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
