Hi Gary! In the generic package would go the Generic(Keyed)ObjectPool and related Configuration/Factory, and agreed, ref sounds better than reference :) What does anyone think about it? Simo
http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Dec 22, 2010 at 6:43 PM, Gary Gregory <ggreg...@seagullsoftware.com> wrote: > On Dec 22, 2010, at 9:43, Simone Tripodi <simone.trip...@gmail.com> wrote: > >> Hi all mates, >> I'd like to propose a small stuff reorganization in the `impl` package >> that is growing up and we could arrange stuff in a cleaner way. >> I propose the following packages: >> >> org.apache.commons.pool2.impl >> |---- generic >> |---- reference >> |---- stack >> >> common stuff could be included directly under impl. >> >> Moreover since we've the SoftReference pool implementation, I propose >> to add a full set of java.lang.ref.Reference pool implementation, the >> current one could become an abstract class using data structures of >> java.lang.ref.Reference references, subclass just provide >> PhantomReference, SoftReference and WeakReference specialization. >> WDYT? Many thanks in advance for feedbacks/suggestions. > > If we do a package for reference code I would suggest to use the same name as > in the jre: "ref" instead of "reference" > > Gary > >> Simo >> >> PS In the meantime, I'm taking care of removing synchronized methods >> and making fields volatile, please review when having spare time! :) >> Have a nice day, >> Simo >> >> http://people.apache.org/~simonetripodi/ >> http://www.99soft.org/ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org