On 13 October 2010 18:32, <simonetrip...@apache.org> wrote: > Author: simonetripodi > Date: Wed Oct 13 17:32:37 2010 > New Revision: 1022205 > > URL: http://svn.apache.org/viewvc?rev=1022205&view=rev > Log: > fixed deprecated properties direct access > added missing setters > syncronized mutable properties (s|g)etters
I think createPool also needs to be synchronised, as it references the various mutable fields. Alternatively, could make them all volatile. Otherwise if one thread sets the value and another calls createPool, the second thread might not see the latest value. But perhaps the PoolFactory class does not need to be thread-safe at all, in which case the synch. can be dropped? At present it appears to be thread-safe, but it is only conditionally thread-safe. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
